"Operator '[]' is not applicable to an Undef Value", at setting.pp

[Turin86]

Describe the Bug

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Operator '[]' is not applicable to an Undef Value. (file: /etc/puppetlabs/code/environments/production/modules/apt/manifests/setting.pp, line: 58, column: 12) (file: /etc/puppetlabs/code/environments/production/manifests/classes/apt-unattended-upgrades.pp, line: 9)

Steps to Reproduce

#
class apt_unattended_upgrades {
  $packages = [
    'unattended-upgrades',
  ]
  package { $packages: ensure => installed } ->

  if $facts['os']['distro']['id'] in ['Debian', 'Ubuntu'] {
    apt::setting { 'conf-auto-upgrades':
      notify_update => false,
      priority      => 20,
      content       => "APT::Periodic::Update-Package-Lists \"1\";\nAPT::Periodic::Unattended-Upgrade \"1\";\nAPT::Periodic::MaxAge \"7\";\n",
    }
    apt::setting { 'conf-unattended-upgrades-background':
      notify_update => false,
      priority      => 61,
      content       => "Unattended-Upgrade::InstallOnShutdown \"false\";\n",
    }
    apt::setting { 'conf-unattended-upgrades-autoremove':
      notify_update => false,
      priority      => 62,
      content       => "Unattended-Upgrade::Remove-Unused-Dependencies \"true\";\n",
    }
  }
}

Environment

• Puppetserver version: puppetserver version: 7.17.1
• Puppet agent version: 8.10.0
• Module: puppetlabs-apt (v9.4.0)
• Platform: Debian GNU/Linux 12 (bookworm)

[bwitt]

@Turin86 does it happen with puppetserver 8? puppetserver 7 is EOL I think

[Turin86]

Let me upgrade the puppetserver and answer that.

[Turin86]

Sorry, it seems to throw a different error now :(

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Unknown variable: 'apt::config_files'. (file: /etc/puppet/code/environments/production/modules/apt/manifests/setting.pp, line: 58, column: 12) (file: /etc/puppet/code/environments/production/manifests/classes/apt-unattended-upgrades.pp, line: 9)

While trying to upgrade the puppetlabs-apt module I get another error:

puppet module upgrade puppetlabs-apt

Notice: Preparing to upgrade 'puppetlabs-apt' ...
Notice: Found 'puppetlabs-apt' (v9.4.0) in /etc/puppet/code/environments/production/modules ...
Notice: Downloading from https://forgeapi.puppet.com ...
Error: Could not upgrade module 'puppetlabs-apt' (v9.4.0 -> latest)
There are 4 newer versions
No combination of dependency upgrades would satisfy all dependencies
Dependencies will not be automatically upgraded across major versions
Upgrading one or more of these modules may permit the upgrade to succeed:
- puppetlabs-stdlib
Use puppet module upgrade --force to upgrade only this module

But it seems that puppetlabs-stdlib is at the latest version:

puppet module upgrade puppetlabs-stdlib

Notice: Preparing to upgrade 'puppetlabs-stdlib' ...
Notice: Found 'puppetlabs-stdlib' (v9.7.0) in /etc/puppet/code/environments/production/modules ...
Notice: Downloading from https://forgeapi.puppet.com ...
Notice: Could not upgrade module 'puppetlabs-stdlib' (v9.7.0 -> latest)
The installed version is already the latest version matching v9.7.0 -> latest
Use puppet module upgrade --force to upgrade only this module

[Turin86]

I have fixed this by adding a "include apt" line in manifests/setting.pp:

define apt::setting (
  Variant[String[1], Integer[0]] $priority = 50,
  Enum['file', 'present', 'absent'] $ensure = file,
  Optional[String[1]] $source = undef,
  Optional[String[1]] $content = undef,
  Boolean $notify_update = true,
) {
  include apt

  if $content and $source {
    fail('apt::setting cannot have both content and source')
  }

  if $ensure != 'absent' {
    if !$content and !$source {
      fail('apt::setting needs either of content or source')
    }
  }