Skip to content

Commit dbf422c

Browse files
author
Isaac Shapira
committed
addressing comments
1 parent a999722 commit dbf422c

File tree

2 files changed

+29
-23
lines changed

2 files changed

+29
-23
lines changed

README.md

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@
2828
type TranslateTransform = { translateY :: Number, translateX :: Number }
2929

3030

31-
### Type Class Instances
32-
33-
instance showLineCap :: Show LineCap
34-
35-
3631
### Values
3732

3833
arc :: forall eff. Context2D -> Arc -> Eff (canvas :: Canvas | eff) Context2D

src/Graphics/Canvas.purs

Lines changed: 29 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -23,24 +23,38 @@ foreign import getContext2D
2323
\}" :: forall eff. CanvasElement -> Eff (canvas :: Canvas | eff) Context2D
2424

2525
foreign import getCanvasWidth
26-
"function getCanvasWidth(canvas){ return function(){ return canvas.width; };};"
27-
:: forall eff. CanvasElement -> Eff (canvas :: Canvas | eff) Number
26+
"function getCanvasWidth(canvas){\
27+
\ return function(){\
28+
\ return canvas.width;\
29+
\ };\
30+
\};" :: forall eff. CanvasElement -> Eff (canvas :: Canvas | eff) Number
2831

2932
foreign import getCanvasHeight
30-
"function getCanvasHeight(canvas){ return function(){ return canvas.height; };};"
31-
:: forall eff. CanvasElement -> Eff (canvas :: Canvas | eff) Number
33+
"function getCanvasHeight(canvas){\
34+
\ return function(){\
35+
\ return canvas.height;\
36+
\ };\
37+
\};" :: forall eff. CanvasElement -> Eff (canvas :: Canvas | eff) Number
3238

3339
foreign import setCanvasWidth
34-
"function setCanvasWidth(width){ return function(canvas){ return function(){\
35-
\ canvas.width = width;\
36-
\ return canvas; \
37-
\};};};" :: forall eff. Number -> CanvasElement -> Eff (canvas :: Canvas | eff) CanvasElement
40+
"function setCanvasWidth(width){\
41+
\ return function(canvas){\
42+
\ return function(){\
43+
\ canvas.width = width;\
44+
\ return canvas;\
45+
\ };\
46+
\ };\
47+
\};" :: forall eff. Number -> CanvasElement -> Eff (canvas :: Canvas | eff) CanvasElement
3848

3949
foreign import setCanvasHeight
40-
"function setCanvasHeight(height){ return function(canvas){ return function(){\
41-
\ canvas.height = height;\
42-
\ return canvas; \
43-
\};};};" :: forall eff. Number -> CanvasElement -> Eff (canvas :: Canvas | eff) CanvasElement
50+
"function setCanvasHeight(height){\
51+
\ return function(canvas){\
52+
\ return function(){\
53+
\ canvas.height = height;\
54+
\ return canvas; \
55+
\ };\
56+
\ };\
57+
\};" :: forall eff. Number -> CanvasElement -> Eff (canvas :: Canvas | eff) CanvasElement
4458

4559
type Dimensions = {width :: Number, height :: Number}
4660

@@ -129,11 +143,6 @@ foreign import setShadowOffsetY
129143

130144
data LineCap = Round | Square | Butt
131145

132-
instance showLineCap :: Show LineCap where
133-
show Round = "round"
134-
show Square = "square"
135-
show Butt = "butt"
136-
137146
foreign import setLineCapImpl
138147
"function setLineCapImpl(cap){\
139148
\ return function(ctx) {\
@@ -145,7 +154,9 @@ foreign import setLineCapImpl
145154
\}" :: forall eff. String -> Context2D -> Eff (canvas :: Canvas | eff) Context2D
146155

147156
setLineCap :: forall eff. LineCap -> Context2D -> Eff (canvas :: Canvas | eff) Context2D
148-
setLineCap cap ctx = setLineCapImpl (show cap) ctx
157+
setLineCap Round = setLineCapImpl "round"
158+
setLineCap Square = setLineCapImpl "square"
159+
setLineCap Butt = setLineCapImpl "butt"
149160

150161
-- |
151162
-- Paths

0 commit comments

Comments
 (0)