Skip to content

Commit 91dfa95

Browse files
committed
* suggested changes done
1 parent 7111058 commit 91dfa95

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

docs/sphinx/source/whatsnew/v0.7.0.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ API Breaking Changes
1919
of W/m2 rather than suns.
2020
* Calling :py:func:`pvlib.pvsystem.retrieve_sam` with no parameters will raise
2121
an exception instead of displaying a dialog.
22+
* The `modelchain.ModelChain.diode_params` attribute is now formatted in
23+
a pandas.DataFrame with `DatetimeIndex`, rather than in a tuple.
2224

2325
API Changes with Deprecations
2426
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -108,8 +110,6 @@ API Changes with Deprecations
108110
argument for capability during the deprecation period.
109111
* Parameter `pvsystem.DC_MODEL_PARAMS` is renamed to `pvsystem._DC_MODEL_PARAMS`.
110112
Users should not rely on this dictionary's existence or structure.
111-
* The `modelchain.ModelChain.diode_params` attribute is now formatted in
112-
a pandas.DataFrame with `DatetimeIndex`, rather than in a tuple.
113113

114114
Other API Changes
115115
~~~~~~~~~~~~~~~~~

pvlib/modelchain.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -929,7 +929,8 @@ def run_model(self, weather, times=None):
929929
930930
Assigns attributes: solar_position, airmass, irradiance,
931931
total_irrad, effective_irradiance, weather, cell_temperature, aoi,
932-
aoi_modifier, spectral_modifier, dc, ac, losses, diode_params.
932+
aoi_modifier, spectral_modifier, dc, ac, losses,
933+
diode_params (if dc_model is a single diode model).
933934
"""
934935
if times is not None:
935936
warnings.warn('times keyword argument is deprecated and will be '

0 commit comments

Comments
 (0)