Fix getting dynamic metadata from hooks for environments (#563)

Author: ofek

docs/history.md

@@ -10,6 +10,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ### Unreleased
 
+***Fixed:***
+
+- Fix getting dynamic metadata from hooks for environments when dependencies are not dynamic
+
 ### [1.6.1](https://github.com/pypa/hatch/releases/tag/hatch-v1.6.1) - 2022-10-16 ### {: #hatch-v1.6.1 }
 
 ***Fixed:***

src/hatch/cli/version/__init__.py

@@ -16,8 +16,9 @@ def version(app, desired_version):
     from hatchling.dep.core import dependencies_in_sync
 
     with app.project.location.as_cwd():
-        dynamic_version = 'version' in app.project.metadata.dynamic
-        if not dynamic_version or dependencies_in_sync(app.project.metadata.build.requires_complex):
+        if not app.project.metadata.hatch.metadata.hook_config or dependencies_in_sync(
+            app.project.metadata.build.requires_complex
+        ):
             source = app.project.metadata.hatch.version.source
 
             version_data = source.get_version_data()

src/hatch/env/plugin/interface.py

@@ -440,7 +440,6 @@ def features(self):
             if not isinstance(features, list):
                 raise TypeError(f'Field `tool.hatch.envs.{self.name}.features` must be an array of strings')
 
-            dynamic_features = 'optional-dependencies' in self.metadata.dynamic
             all_features = set()
             for i, feature in enumerate(features, 1):
                 if not isinstance(feature, str):
@@ -452,7 +451,10 @@ def features(self):
 
                 if not self.metadata.hatch.metadata.allow_ambiguous_features:
                     feature = normalize_project_name(feature)
-                if not dynamic_features and feature not in self.metadata.core.optional_dependencies:
+                if (
+                    not self.metadata.hatch.metadata.hook_config
+                    and feature not in self.metadata.core.optional_dependencies
+                ):
                     raise ValueError(
                         f'Feature `{feature}` of field `tool.hatch.envs.{self.name}.features` is not '
                         f'defined in field `project.optional-dependencies`'

src/hatch/utils/dep.py

@@ -17,11 +17,9 @@ def get_project_dependencies_complex(environment):
     dependencies_complex = {}
     optional_dependencies_complex = {}
 
-    dynamic_fields = environment.metadata.dynamic
-    if 'dependencies' not in dynamic_fields and 'optional-dependencies' not in dynamic_fields:
-        dependencies_complex.update(environment.metadata.core.dependencies_complex)
-        optional_dependencies_complex.update(environment.metadata.core.optional_dependencies_complex)
-    elif dependencies_in_sync(environment.metadata.build.requires_complex):
+    if not environment.metadata.hatch.metadata.hook_config or dependencies_in_sync(
+        environment.metadata.build.requires_complex
+    ):
         dependencies_complex.update(environment.metadata.core.dependencies_complex)
         optional_dependencies_complex.update(environment.metadata.core.optional_dependencies_complex)
     else:

tests/cli/dep/show/test_requirements.py

@@ -13,7 +13,7 @@ def test_incompatible_environment(hatch, temp_dir, helpers):
     project = Project(path)
     config = dict(project.raw_config)
     config['build-system']['requires'].append('foo')
-    config['project']['dynamic'].append('dependencies')
+    config['tool']['hatch']['metadata'] = {'hooks': {'custom': {}}}
     project.save_config(config)
     helpers.update_project_environment(
         project, 'default', {'skip-install': True, 'python': '9000', **project.config.envs['default']}

tests/cli/dep/show/test_table.py

@@ -22,7 +22,7 @@ def test_incompatible_environment(hatch, temp_dir, helpers):
     project = Project(path)
     config = dict(project.raw_config)
     config['build-system']['requires'].append('foo')
-    config['project']['dynamic'].append('dependencies')
+    config['tool']['hatch']['metadata'] = {'hooks': {'custom': {}}}
     project.save_config(config)
     helpers.update_project_environment(
         project, 'default', {'skip-install': True, 'python': '9000', **project.config.envs['default']}

tests/cli/dep/test_hash.py

@@ -15,7 +15,7 @@ def test_incompatible_environment(hatch, temp_dir, helpers):
     project = Project(path)
     config = dict(project.raw_config)
     config['build-system']['requires'].append('foo')
-    config['project']['dynamic'].append('dependencies')
+    config['tool']['hatch']['metadata'] = {'hooks': {'custom': {}}}
     project.save_config(config)
     helpers.update_project_environment(
         project, 'default', {'skip-install': True, 'python': '9000', **project.config.envs['default']}

tests/cli/version/test_version.py

@@ -14,6 +14,7 @@ def test_incompatible_environment(hatch, temp_dir, helpers):
     project = Project(path)
     config = dict(project.raw_config)
     config['build-system']['requires'].append('foo')
+    config['tool']['hatch']['metadata'] = {'hooks': {'custom': {}}}
     project.save_config(config)
     helpers.update_project_environment(
         project, 'default', {'skip-install': True, 'python': '9000', **project.config.envs['default']}

tests/env/plugin/test_interface.py

@@ -4,6 +4,7 @@
 from hatch.env.plugin.interface import EnvironmentInterface
 from hatch.project.core import Project
 from hatch.utils.structures import EnvVars
+from hatchling.utils.constants import DEFAULT_BUILD_SCRIPT
 
 
 class MockEnvironment(EnvironmentInterface):  # no cov
@@ -636,14 +637,31 @@ def test_full_dev_mode(self, isolation, isolated_data_dir, platform):
 
         assert environment.dependencies == ['dep2', 'dep3']
 
-    def test_unknown_dynamic_feature(self, isolation, isolated_data_dir, platform):
+    def test_unknown_dynamic_feature(self, helpers, temp_dir, isolated_data_dir, platform):
         config = {
             'project': {'name': 'my_app', 'version': '0.0.1', 'dynamic': ['optional-dependencies']},
-            'tool': {'hatch': {'envs': {'default': {'skip-install': False, 'features': ['foo']}}}},
+            'tool': {
+                'hatch': {
+                    'metadata': {'hooks': {'custom': {}}},
+                    'envs': {'default': {'skip-install': False, 'features': ['foo']}},
+                },
+            },
         }
-        project = Project(isolation, config=config)
+        project = Project(temp_dir, config=config)
         environment = MockEnvironment(
-            isolation, project.metadata, 'default', project.config.envs['default'], {}, isolated_data_dir, platform, 0
+            temp_dir, project.metadata, 'default', project.config.envs['default'], {}, isolated_data_dir, platform, 0
+        )
+
+        build_script = temp_dir / DEFAULT_BUILD_SCRIPT
+        build_script.write_text(
+            helpers.dedent(
+                """
+                from hatchling.metadata.plugin.interface import MetadataHookInterface
+                class CustomHook(MetadataHookInterface):
+                    def update(self, metadata):
+                        metadata['optional-dependencies'] = {'bar': ['binary']}
+                """
+            )
         )
 
         with pytest.raises(