gh-152849: Address review comments

tonghuaroot · tonghuaroot · commit a23c23f96656 · 2026-07-02T15:55:41.000+08:00
diff --git a/Lib/test/test_time.py b/Lib/test/test_time.py
@@ -1015,10 +1015,13 @@ def test_FromSecondsObject(self):
 
     def test_FromSecondsObject_float_overflow_message(self):
         # Float path must report a PyTime_t overflow, like the integer path.
+        from _testcapi import PyTime_MIN, PyTime_MAX
         from _testinternalcapi import _PyTime_FromSecondsObject
-        for value in (2.0 ** 63, -(2.0 ** 63)):
+        for value in (float(PyTime_MAX), float(PyTime_MIN)):
             for time_rnd, _ in ROUNDING_MODES:
-                with self.assertRaisesRegex(OverflowError, "to C PyTime_t"):
+                with self.assertRaisesRegex(
+                        OverflowError,
+                        "timestamp out of range for C PyTime_t"):
                     _PyTime_FromSecondsObject(value, time_rnd)
 
     def test_AsSecondsDouble(self):
diff --git a/Misc/NEWS.d/next/Library/2026-07-02-13-30-00.gh-issue-152849.K9dRvP.rst b/Misc/NEWS.d/next/Library/2026-07-02-13-30-00.gh-issue-152849.K9dRvP.rst
diff --git a/Python/pytime.c b/Python/pytime.c
@@ -107,7 +107,7 @@ static void
 pytime_overflow(void)
 {
     PyErr_SetString(PyExc_OverflowError,
-                    "timestamp too large to convert to C PyTime_t");
+                    "timestamp out of range for C PyTime_t");
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ static void`
`107`	`107`	`pytime_overflow(void)`
`108`	`108`	`{`
`109`	`109`	`PyErr_SetString(PyExc_OverflowError,`
`110`		`- "timestamp too large to convert to C PyTime_t");`
	`110`	`+ "timestamp out of range for C PyTime_t");`
`111`	`111`	`}`
`112`	`112`
`113`	`113`