Skip to content

Commit a9b9589

Browse files
Simplify code execution in test_get_message by only using exec
Refactor test_get_message to simplify code execution.
1 parent 1c5c8a0 commit a9b9589

1 file changed

Lines changed: 3 additions & 12 deletions

File tree

Lib/idlelib/idle_test/test_run.py

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,7 @@ def test_get_message(self):
5353
for code, exc, msg in self.data:
5454
with self.subTest(code=code):
5555
try:
56-
if "raise" not in code:
57-
eval(compile(code, '', 'eval'))
58-
else:
59-
exec(compile(code, '', 'exec')) # code r"raise NameError("123\n456")" cannot run in "eval" mode: SyntaxError
56+
exec(compile(code, '', 'exec'))
6057
except exc:
6158
typ, val, tb = sys.exc_info()
6259
actual = run.get_message_lines(typ, val, tb)[0]
@@ -78,16 +75,10 @@ def test_get_multiple_message(self, mock):
7875
for (code1, exc1, msg1), (code2, exc2, msg2) in data2:
7976
with self.subTest(codes=(code1,code2)):
8077
try:
81-
if "raise" not in code1:
82-
eval(compile(code1, '', 'eval'))
83-
else:
84-
exec(compile(code1, '', 'exec'))
78+
exec(compile(code1, '', 'exec'))
8579
except exc1:
8680
try:
87-
if "raise" not in code2:
88-
eval(compile(code2, '', 'eval'))
89-
else:
90-
exec(compile(code2, '', 'exec'))
81+
exec(compile(code2, '', 'exec'))
9182
except exc2:
9283
with captured_stderr() as output:
9384
run.print_exception()

0 commit comments

Comments
 (0)