Possible bad copypaste at ceval_gil.c

[partimScurra]

Static analysis tool indicates that, at make_pending_calls func, pending might be pending_main because of the preceding if statement.
Not sure if this is intended logic or not, so clarification is welcome!

https://github.com/python/cpython/blame/d6d054853dd1be3c3b95902abc26537389c83836/Python/ceval_gil.c#L959

[picnixz]

What is the issue with this? This just sets the handling thread to NULL.

cc @colesbury

[sergey-miryanov]

There is no need to clear pending_main, because there are no writes to pending_main->handling_thread.

[picnixz]

If _make_pending_calls(pending, &npending) succeeds but _make_pending_calls(pending_main, &npending) fails, then pending->handling_thread will be set to tstate. We want it to be reset before exiting.

[vstinner]

Not sure if this is intended logic or not, so clarification is welcome!

It looks like a false alarm to me, the logic looks correct to me.

[colesbury]

Yeah, the existing code looks correct to me and I agree with @picnixz's explanation above.