Commit 812a3c8
committed
[mypyc] Revert PyObject_GetOptionalAttrString in module shims
PyObject_GetOptionalAttrString was added in CPython 3.13, but the shim
templates #include only <Python.h> -- they don't see CPy.h or the
pythoncapi_compat.h shim from lib-rt -- so on 3.10/3.11/3.12 CI all
shim builds fail with "implicit declaration of function
'PyObject_GetOptionalAttrString'" under -Werror.
Mypy supports 3.10+, so go back to the portable
PyObject_GetAttrString + PyErr_Clear form. Leaving a comment in both
templates explaining why we can't use the cleaner API here.1 parent 6d488bf commit 812a3c8
2 files changed
Lines changed: 14 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
| 40 | + | |
| 41 | + | |
40 | 42 | | |
41 | 43 | | |
42 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| 39 | + | |
| 40 | + | |
39 | 41 | | |
40 | 42 | | |
41 | 43 | | |
| |||
0 commit comments