Skip to content

Performance: Speed up of deepcopy for Miller #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Performance: Speed up of deepcopy for Miller #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion orix/vector/miller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,10 @@ def from_min_dspacing(

def deepcopy(self) -> Miller:
"""Return a deepcopy of the instance."""
return deepcopy(self)
data = deepcopy(self.data) # Otherwise, data is a view
copied = self.__class__(xyz=data, phase=self.phase) # deepcopy is slow.
copied.coordinate_format = self.coordinate_format
return copied

def round(self, max_index: int = 20) -> Miller:
"""Round a set of index triplet (Miller) or quartet
Expand Down