Merge pull request #203 from r-spatial/cran-fixes-latest

Maybe fix latest cran warnings

Author: edzer

src/absl/container/internal/raw_hash_set.h

@@ -324,7 +324,11 @@ inline bool IsEmptyOrDeleted(ctrl_t c) { return c < kSentinel; }
 // Work around this by using the portable implementation of Group
 // when using -funsigned-char under GCC.
 inline __m128i _mm_cmpgt_epi8_fixed(__m128i a, __m128i b) {
-#if defined(__GNUC__) && !defined(__clang__)
+// dd: in the latest gcc we get warnings about overflow here.
+// the linked bug was fixed in gcc 9 and fixes were backported
+// to gcc 7 and 8 patch releases. To fix the warning, I just
+// added a check for the GCC version.
+#if defined(__GNUC__) && (__GNUC__ < 9) && !defined(__clang__)
   if (std::is_unsigned<char>::value) {
     const __m128i mask = _mm_set1_epi8(0x80);
     const __m128i diff = _mm_subs_epi8(b, a);

src/s2/util/math/exactfloat/exactfloat.cc

@@ -409,7 +409,7 @@ std::string ExactFloat::ToStringWithMaxDigits(int max_digits) const {
       str.append(digits.begin() + 1, digits.end());
     }
     char exp_buf[20];
-    sprintf(exp_buf, "e%+02d", exp10 - 1);
+    snprintf(exp_buf, sizeof(exp_buf), "e%+02d", exp10 - 1);
     str += exp_buf;
   } else {
     // Use fixed format.  We split this into two cases depending on whether
@@ -512,7 +512,7 @@ int ExactFloat::GetDecimalDigits(int max_digits, std::string* digits) const {
 
 std::string ExactFloat::ToUniqueString() const {
   char prec_buf[20];
-  sprintf(prec_buf, "<%d>", prec());
+  snprintf(prec_buf, sizeof(prec_buf), "<%d>", prec());
   return ToString() + prec_buf;
 }