continue Durbin factors

Author: rsbivand

R/spBreg.R

@@ -1329,8 +1329,12 @@ spBreg_sac <- function(formula, data = list(), listw, listw2=NULL, na.action,
 	        lambda2 = lambda + cc2*rnorm(1)
 	    }
         }
-        i1 = max(which(detval21 <= (lambda2 + gsize2)))
-	i2 = max(which(detval21 <= (lambda2 - gsize2)))
+        i1 <- which(detval21 <= (lambda2 + gsize2))
+        if (length(i1) == 0L) i1 <- -Inf
+        else i1 = max(i1)
+        i2 <- which(detval21 <= (lambda2 - gsize2))
+	if (length(i2) == 0L) i2 <- -Inf
+        else i2 = max(i2)
         index = round((i1+i2)/2)
         if (!is.finite(index)) index = 1 #Fixed this
 	detm = detval22[index]

inst/tinytest/test_Durbin_factor.R

@@ -83,6 +83,10 @@ expect_warning(COL.lag1a <- spBreg_lag(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL
 expect_warning(COL.lag2a <- spBreg_lag(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL + fDISCBD))
 expect_silent(COL.lag3a <- spBreg_lag(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL))
 Sys.setenv("SPATIALREG_CREATE_DURBIN"="")
+expect_true(isTRUE(all.equal(attr(COL.lag0, "dvars"), attr(COL.lag0a, "dvars"))))
+expect_true(isTRUE(all.equal(attr(COL.lag1, "dvars"), attr(COL.lag1a, "dvars"))))
+expect_true(isTRUE(all.equal(attr(COL.lag2, "dvars"), attr(COL.lag2a, "dvars"))))
+expect_true(isTRUE(all.equal(attr(COL.lag3, "dvars"), attr(COL.lag3a, "dvars"))))
 expect_warning(COL.err0 <- spBreg_err(f, data=COL.OLD, lw, Durbin=TRUE))
 expect_warning(COL.err1 <- spBreg_err(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL + fDISCBD*fEW))
 expect_warning(COL.err2 <- spBreg_err(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL + fDISCBD))
@@ -93,4 +97,22 @@ expect_warning(COL.err1a <- spBreg_err(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL
 expect_warning(COL.err2a <- spBreg_err(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL + fDISCBD))
 expect_silent(COL.err3a <- spBreg_err(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL))
 Sys.setenv("SPATIALREG_CREATE_DURBIN"="")
+expect_true(isTRUE(all.equal(attr(COL.err0, "dvars"), attr(COL.err0a, "dvars"))))
+expect_true(isTRUE(all.equal(attr(COL.err1, "dvars"), attr(COL.err1a, "dvars"))))
+expect_true(isTRUE(all.equal(attr(COL.err2, "dvars"), attr(COL.err2a, "dvars"))))
+expect_true(isTRUE(all.equal(attr(COL.err3, "dvars"), attr(COL.err3a, "dvars"))))
+expect_warning(COL.sac0 <- spBreg_sac(f, data=COL.OLD, lw, Durbin=TRUE))
+expect_warning(COL.sac1 <- spBreg_sac(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL + fDISCBD*fEW))
+expect_warning(COL.sac2 <- spBreg_sac(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL + fDISCBD))
+expect_silent(COL.sac3 <- spBreg_sac(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL))
+Sys.setenv("SPATIALREG_CREATE_DURBIN"="0")
+expect_warning(COL.sac0a <- spBreg_sac(f, data=COL.OLD, lw, Durbin=TRUE))
+expect_warning(COL.sac1a <- spBreg_sac(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL + fDISCBD*fEW))
+expect_warning(COL.sac2a <- spBreg_sac(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL + fDISCBD))
+expect_silent(COL.sac3a <- spBreg_sac(f, data=COL.OLD, lw, Durbin=~ INC + HOVAL))
+Sys.setenv("SPATIALREG_CREATE_DURBIN"="")
+expect_true(isTRUE(all.equal(attr(COL.sac0, "dvars"), attr(COL.sac0a, "dvars"))))
+expect_true(isTRUE(all.equal(attr(COL.sac1, "dvars"), attr(COL.sac1a, "dvars"))))
+expect_true(isTRUE(all.equal(attr(COL.sac2, "dvars"), attr(COL.sac2a, "dvars"))))
+expect_true(isTRUE(all.equal(attr(COL.sac3, "dvars"), attr(COL.sac3a, "dvars"))))