From bcd00831fecea02d2941777e2b2289fcb2433982 Mon Sep 17 00:00:00 2001
From: Victor Ramirez <victor@railway.com>
Date: Wed, 8 Jul 2026 15:48:07 +0200
Subject: [PATCH 1/2] Warn on config pull when the installed SDK runner is
 outdated

A customer on CLI v5.23.3 (which contains the volume rendering fix from
#989) still pulled configs with volumes missing. The renderer, the SDK
graph, and the server serialization all handle volumes; the failure is
version skew: config pull runs the project-installed railway SDK, and
pre-3.4.0 versions emit volume-less graphs with nothing flagging the
omission.

railway-ts-sdk now stamps every runner response with sdkVersion; pull
warns when the field is absent (any pre-handshake SDK) so silent
resource dropout becomes a visible upgrade prompt. Also adds the
missing renderer regression test covering volume declarations,
name collisions, database volumes, and attachments.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 src/commands/config/mod.rs    | 76 +++++++++++++++++++++++++++++++++++
 src/commands/config/runner.rs |  3 ++
 2 files changed, 79 insertions(+)

diff --git a/src/commands/config/mod.rs b/src/commands/config/mod.rs
index b99ed547e..a28c09090 100644
--- a/src/commands/config/mod.rs
+++ b/src/commands/config/mod.rs
@@ -407,6 +407,15 @@ async fn load_current_graph(runner: Option<String>) -> Result<runner::DesiredGra
     let _ = fs::remove_file(temp_file);
     let _ = fs::remove_dir(temp_dir);
 
+    if response.sdk_version.is_none() {
+        println!(
+            "{} The installed {} package is outdated and may omit resources (like volumes) from the imported config. Upgrade it with {}.",
+            "Warning:".yellow().bold(),
+            "railway".cyan(),
+            "npm install railway@latest".cyan()
+        );
+    }
+
     if !response.ok {
         let diagnostics = response
             .diagnostics
@@ -1411,4 +1420,71 @@ mod tests {
         assert!(rendered.contains("source: image"));
         assert!(rendered.contains("registryCredentials"));
     }
+
+    #[test]
+    fn pull_renderer_declares_volumes_and_attachments() {
+        let graph: runner::DesiredGraph = serde_json::from_value(json!({
+            "project": { "name": "acme" },
+            "resources": [
+                {
+                    "address": "service.web",
+                    "type": "service",
+                    "name": "web",
+                    "source": { "type": "image", "image": "ghcr.io/acme/api:1.2.3" },
+                    "deploy": { "startCommand": "node index.js" },
+                    "volumeAttachments": {
+                        "web": { "volume": "volume.web", "mountPath": "/data" }
+                    }
+                },
+                {
+                    "address": "database.db",
+                    "type": "database",
+                    "engine": "postgres",
+                    "name": "db",
+                    "deploy": { "requiredMountPath": "/var/lib/postgresql/data" }
+                },
+                { "address": "volume.web", "type": "volume", "name": "web", "config": { "name": "web", "sizeMB": 1024 } },
+                { "address": "volume.db-volume", "type": "volume", "name": "db-volume", "config": { "name": "db-volume", "sizeMB": 2048 } },
+                { "address": "volume.scratch", "type": "volume", "name": "scratch", "config": { "name": "scratch", "sizeMB": 512 } }
+            ]
+        }))
+        .expect("valid graph json");
+
+        let out = render_graph_as_railway_ts(&graph, false);
+
+        // Volume names colliding with service names, database volumes, and
+        // unattached volumes must all be declared and referenced.
+        assert!(out.contains("volume(\"web\""), "missing volume(web): {out}");
+        assert!(
+            out.contains("volume(\"db-volume\""),
+            "missing volume(db-volume): {out}"
+        );
+        assert!(
+            out.contains("volume(\"scratch\""),
+            "missing volume(scratch): {out}"
+        );
+        assert!(out.contains("volumeMounts"), "missing attachment: {out}");
+    }
+
+    #[test]
+    fn runner_response_surfaces_sdk_version() {
+        let with_version: runner::RunnerResponse = serde_json::from_value(json!({
+            "ok": true,
+            "command": "current",
+            "file": "railway.ts",
+            "sdkVersion": "3.5.3",
+            "diagnostics": []
+        }))
+        .expect("valid response");
+        assert_eq!(with_version.sdk_version.as_deref(), Some("3.5.3"));
+
+        let without_version: runner::RunnerResponse = serde_json::from_value(json!({
+            "ok": true,
+            "command": "current",
+            "file": "railway.ts",
+            "diagnostics": []
+        }))
+        .expect("valid response");
+        assert!(without_version.sdk_version.is_none());
+    }
 }
diff --git a/src/commands/config/runner.rs b/src/commands/config/runner.rs
index 665f436c6..a4762bf49 100644
--- a/src/commands/config/runner.rs
+++ b/src/commands/config/runner.rs
@@ -70,6 +70,9 @@ pub(super) struct RunnerResponse {
     pub(super) ok: bool,
     command: String,
     file: String,
+    /// Absent when the installed railway SDK predates the version handshake.
+    #[serde(default)]
+    pub(super) sdk_version: Option<String>,
     current_environment: Option<CurrentEnvironment>,
     pub(super) change_set: Option<ChangeSet>,
     diff: Option<String>,

From ab1e8258777fe2aa3089bbb15fe1e614089bc939 Mon Sep 17 00:00:00 2001
From: Victor Ramirez <victor@railway.com>
Date: Wed, 8 Jul 2026 16:04:09 +0200
Subject: [PATCH 2/2] Generalize outdated-SDK warning to all config commands

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 src/commands/config/mod.rs    |  9 ---------
 src/commands/config/runner.rs | 21 +++++++++++++++++++++
 2 files changed, 21 insertions(+), 9 deletions(-)

diff --git a/src/commands/config/mod.rs b/src/commands/config/mod.rs
index a28c09090..e735fc80c 100644
--- a/src/commands/config/mod.rs
+++ b/src/commands/config/mod.rs
@@ -407,15 +407,6 @@ async fn load_current_graph(runner: Option<String>) -> Result<runner::DesiredGra
     let _ = fs::remove_file(temp_file);
     let _ = fs::remove_dir(temp_dir);
 
-    if response.sdk_version.is_none() {
-        println!(
-            "{} The installed {} package is outdated and may omit resources (like volumes) from the imported config. Upgrade it with {}.",
-            "Warning:".yellow().bold(),
-            "railway".cyan(),
-            "npm install railway@latest".cyan()
-        );
-    }
-
     if !response.ok {
         let diagnostics = response
             .diagnostics
diff --git a/src/commands/config/runner.rs b/src/commands/config/runner.rs
index a4762bf49..1ae1fe771 100644
--- a/src/commands/config/runner.rs
+++ b/src/commands/config/runner.rs
@@ -444,9 +444,30 @@ async fn invoke_runner(
         format!("IaC runner returned non-JSON output.\nstdout:\n{stdout}\nstderr:\n{stderr}")
     })?;
 
+    warn_outdated_runner(&response);
+
     Ok(response)
 }
 
+/// Responses without sdkVersion come from SDKs that predate the version
+/// handshake. Warn once per invocation, on stderr so --json output stays clean.
+fn warn_outdated_runner(response: &RunnerResponse) {
+    use colored::Colorize;
+
+    static WARN_ONCE: std::sync::Once = std::sync::Once::new();
+    if response.sdk_version.is_some() {
+        return;
+    }
+    WARN_ONCE.call_once(|| {
+        eprintln!(
+            "{} You are running an outdated version of the {} SDK, which may result in undesired behavior. Upgrade it with {}.",
+            "Warning:".yellow().bold(),
+            "railway".cyan(),
+            "npm install railway@latest".cyan(),
+        );
+    });
+}
+
 struct ResolvedRunner {
     path: String,
     source: RunnerSource,