-
Notifications
You must be signed in to change notification settings - Fork 299
Open
Description
- There's a number of places in r/d and r/r that include milestone specific information.
- We should create a single location to track and align these, then pull from it when needed
- We could have this as a file in the master repo, or push to github pages, package.json?
- Multiple files, one per branch, containing one line VS One file in master with multiple lines
This could solve several problems
- tie r/d branch to milestone - TODO
- image used in e2e jobs - TODO
constfor docs version - TODO- r/r references for ui-dashboard-index and ui-index settings - TODO
- needs discussion with release team
Possible alignment of variables
| Variable | Description | Example | Use Case |
|---|---|---|---|
| r/d branch | rancher/dashboard branch | master, release-2.13 |
this one ties everything together |
| rancher milestone | rancher/dashboard milestone | v2.13.1, v2.12.5 |
used to prevent PRs not associated with branch from merging (pending) |
| image reg and tag | container registry and image tag | v2.12-head, head |
image used in e2e jobs |
| CDN dashboard url | when we build on push, this is where the build lives | TODO | this can be used in r/r ui-dashboard-index setting (r/r → ui branch → url for ui-dashboard-index setting) |
| CDN ember url | when we build on push, this is where the build lives | TODO | this can be used in r/r ui-index setting (r/r → ui branch → url for ui-dashboard-index setting) |
| .. | |||
| TBD | |||
| r/r branch | rancher/rancher branch | main, release-2.13 |
This might cause issues on r/r branch. If we track it in our file WE would need to update when they branch. If we don't track it in our file THEY would need to update to point to our branch when they branch. |