-
Notifications
You must be signed in to change notification settings - Fork 298
Fix pool name overflow in Tabbed component for side-tabs mode #16076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…oltip Co-authored-by: nwmac <[email protected]>
|
@copilot This is not the fix I think we need - the issue is in the create/edit view for provisioning.cattle.io.cluster - look at the rke2.vue file. I think the fix might be needed on the |
Co-authored-by: nwmac <[email protected]>
Co-authored-by: nwmac <[email protected]>
Co-authored-by: nwmac <[email protected]>
You're right, I was fixing the wrong component. I've reverted my changes to the detail view and applied the fix to the The fix adds:
This ensures long pool names are truncated with ellipsis in the vertical tabs of the Machine Pools section in the create/edit cluster view. Commit: 2dac30c Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
nwmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, nice fix. LGTM
Summary
Fixes #15067
Long pool names overflow behind other UI elements in the Machine Pools section of the cluster create/edit view.
Occurred changes and/or fixed issues
Tabbedcomponent to benefit all vertical tabs throughout the applicationTechnical notes summary
CSS changes to
.side-tabs .tabs .tab Ainshell/components/Tabbed/index.vue:overflow: hidden,text-overflow: ellipsis,white-space: nowrap,display: blockto the first span child for text truncationTemplate changes:
titleattribute to the tab label span (conditional onsideTabsmode) to show full name on hoverAreas or cases that should be tested
Areas which could experience regressions
rke2.vue)Tabbedwithside-tabsmodeScreenshot/Video
Before: Pool name overflows behind UI elements
Checklist
Admin,Standard UserandUser BaseOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.