RavenDB-25423 test

Author: Scooletz

Raven.CodeAnalysis.Test/BooleanMethodNegationTests.cs

@@ -106,7 +106,7 @@ public void ShouldReportDiagnosticOnNegatedBooleanMethod_field()
             const string input = @"
 class C
 {
-    private bool HasPermission()
+    internal bool HasPermission()
     {
         return false;
     }
@@ -131,7 +131,7 @@ void M()
                 Severity = DiagnosticSeverity.Error,
                 Locations =
                 [
-                    new DiagnosticResultLocation("Test0.cs", 11, 13)
+                    new DiagnosticResultLocation("Test0.cs", 16, 13)
                 ]
             });
         }

Raven.CodeAnalysis/BooleanMethodNegation/BooleanMethodNegationAnalyzer.cs

@@ -27,12 +27,11 @@ private static void AnalyzeSyntax(SyntaxNodeAnalysisContext context)
                 operand = parenthesizedExpressionSyntax.Expression;
             }
 
-            var invocationExpressionSyntax = operand as InvocationExpressionSyntax;
-            if (invocationExpressionSyntax == null)
+            if (operand is InvocationExpressionSyntax invocation == false)
                 return;
 
             var semanticModel = context.SemanticModel;
-            var methodSymbol = semanticModel.GetSymbolInfo(invocationExpressionSyntax, context.CancellationToken).Symbol as IMethodSymbol;
+            var methodSymbol = semanticModel.GetSymbolInfo(invocation, context.CancellationToken).Symbol as IMethodSymbol;
 
             if (methodSymbol?.ReturnType?.SpecialType != SpecialType.System_Boolean)
                 return;