Narrow the locking window when accessing v4AuthPair map

In this commit

d6abc17 Fix race condition when updating v4AuthPair map

We put in locking to access the v4AuthPair map. However this locking
extended over the HTTP request which means that it effectively made
the server single threaded in certain cases.

This fix narrows the locking window to fix the problem.

See: https://forum.rclone.org/t/can-rclone-serve-s3-handle-more-than-one-client/48329/

Author: ncw

gofakes3.go

@@ -41,8 +41,8 @@ type GoFakeS3 struct {
 	log                     Logger
 
 	// simple v4 signature
+	mu         sync.RWMutex // protects vAuthPair map only
 	v4AuthPair map[string]string
-	mu         sync.RWMutex
 }
 
 // New creates a new GoFakeS3 using the supplied Backend. Backends are pluggable.
@@ -120,8 +120,9 @@ func (g *GoFakeS3) DelAuthKeys(p []string) {
 func (g *GoFakeS3) authMiddleware(handler http.Handler) http.Handler {
 	return http.HandlerFunc(func(w http.ResponseWriter, rq *http.Request) {
 		g.mu.RLock()
-		defer g.mu.RUnlock()
-		if len(g.v4AuthPair) > 0 {
+		haveAuth := len(g.v4AuthPair) > 0
+		g.mu.RUnlock()
+		if haveAuth {
 			if result := signature.V4SignVerify(rq); result != signature.ErrNone {
 				g.log.Print(LogWarn, "Access Denied:", rq.RemoteAddr, "=>", rq.URL)