RDK-61444 : Network Manager Plugin to support Scan Specific SSID by jincysam87 · Pull Request #306 · rdkcentral/networkmanager

jincysam87 · 2026-05-08T15:59:31Z

Reason for change: Support to scan multiple SSIDs
Test Procedure: Test wifi scan API with multiple SSIDs
Risks: Low
Signed-off-by: jincysaramma_sam@comcast.com

Sync

rdkcmf-jenkins · 2026-05-08T16:00:39Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 3a19acc

Report detail: gist'

Copilot

Pull request overview

This PR updates the GNOME NetworkManager WiFi scan path to support scanning with multiple SSID filters (instead of a single optional SSID string), aligning the plugin with the requirement to “scan multiple SSIDs”.

Changes:

Updated wifiScanRequest API to accept a std::vector<std::string> of SSIDs to filter.
Built a GVariant aay SSID list for nm_device_wifi_request_scan_options_async() when filters are provided; otherwise falls back to a normal scan.
Updated the GNOME proxy to pass the SSID filter list through to the WiFi manager.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
plugin/gnome/NetworkManagerGnomeWIFI.h	Changes `wifiScanRequest` signature to take a vector of SSIDs.
plugin/gnome/NetworkManagerGnomeWIFI.cpp	Implements building a multi-SSID scan options payload and triggers filtered vs unfiltered scan.
plugin/gnome/NetworkManagerGnomeProxy.cpp	Passes the SSID filter list to the updated scan request API.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

            bool wifiConnectedSSIDInfo(Exchange::INetworkManager::WiFiSSIDInfo &ssidinfo);
            bool wifiConnect(const Exchange::INetworkManager::WiFiConnectTo &ssidInfo);
-            bool wifiScanRequest(std::string ssidReq = "");
+            bool wifiScanRequest(std::vector<std::string> ssidsToFilter = {});


+            if(!ssidsToFilter.empty())
            {
-                NMLOG_INFO("starting wifi scanning .. %s", ssidReq.c_str());
+                NMLOG_INFO("Starting wifi scanning for %d SSIDs:", ssidsToFilter.size());


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

rdkcmf-jenkins · 2026-05-08T16:06:42Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: ec5d3a2

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

            bool wifiConnectedSSIDInfo(Exchange::INetworkManager::WiFiSSIDInfo &ssidinfo);
            bool wifiConnect(const Exchange::INetworkManager::WiFiConnectTo &ssidInfo);
-            bool wifiScanRequest(std::string ssidReq = "");
+            bool wifiScanRequest(std::vector<std::string> ssidsToFilter = {});


+            if(!ssidsToFilter.empty())
            {
-                NMLOG_INFO("starting wifi scanning .. %s", ssidReq.c_str());
+                NMLOG_INFO("Starting wifi scanning for %d SSIDs:", ssidsToFilter.size());


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

rdkcmf-jenkins · 2026-05-08T16:14:44Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 3aba5bb

Report detail: gist'

rdkcmf-jenkins · 2026-05-08T16:15:33Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 7032c46

Report detail: gist'

rdkcmf-jenkins · 2026-05-22T01:20:43Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 1aed44b

Report detail: gist'

rdkcmf-jenkins · 2026-05-22T01:31:13Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 0cb18b0

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

tests/l2Test/rdk/l2_test_rdkproxy.cpp:677

This test payload uses the frequency parameter name, but the JSON-RPC API implementation/docs for StartWiFiScan now expect frequencies (plural) as an array. As-is, this test can still pass without validating the new request shape.

    EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("StartWiFiScan"), 
        _T("{\"frequency\":[\"2.4\"]}"), response));
    EXPECT_EQ(response, _T("{\"success\":false}"));

plugin/NetworkManagerJsonRpc.cpp:683

index.Current().String() already returns a std::string. Converting it to c_str() and then back to std::string is unnecessary and can truncate values containing embedded NULs (possible in SSIDs represented as JSON strings with \u0000). Push the std::string directly.

                    if (Core::JSON::Variant::type::STRING == index.Current().Content())
                    {
                        ssidslist.push_back(index.Current().String().c_str());
                    }

rdkcmf-jenkins · 2026-05-22T01:40:50Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 0516339

Report detail: gist'

rdkcmf-jenkins · 2026-05-22T02:01:02Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 3af5cf7

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

tests/l2Test/rdk/l2_test_rdkproxy.cpp:677

The JSON-RPC StartWiFiScan handler expects frequencies (plural). Using frequency here means the test does not validate the updated API contract and may ignore the provided filter.

    EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("StartWiFiScan"), 
        _T("{\"frequency\":[\"2.4\"]}"), response));
    EXPECT_EQ(response, _T("{\"success\":false}"));

rdkcmf-jenkins · 2026-05-22T20:39:02Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: d97af8a

Report detail: gist'

rdkcmf-jenkins · 2026-05-22T20:45:22Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 42520a4

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

karuna2git

Changes looks good to me.

rdkcmf-jenkins · 2026-05-27T19:45:27Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 66f1632

Report detail: gist'

rdkcmf-jenkins · 2026-05-27T19:46:21Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 66f1632

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (2)

plugin/gnome/NetworkManagerGnomeWIFI.cpp:1995

This log message is inaccurate: connectionBuilder() failure is not related to a "nm_variant" here, which makes troubleshooting harder.

                    if(!connectionBuilder(wifiConnectInfo, connection, true))
                    {
                        NMLOG_ERROR("wps connection builder failed");
                        break;

interface/INetworkManager.h:112

WIFIFrequency @text annotations still use "2.4GHz"/"5GHz"/"6GHz", while the updated JSON/API documentation and enum conversion map use "2.4"/"5"/"6". This mismatch can lead to inconsistent string<->enum conversions and regenerated schema drift.

            enum WIFIFrequency : uint8_t
            {
                WIFI_FREQUENCY_ALL           /* @text: ALL */,
                WIFI_FREQUENCY_2_4_GHZ       /* @text: 2.4GHz */,
                WIFI_FREQUENCY_5_GHZ         /* @text: 5GHz */,
                WIFI_FREQUENCY_6_GHZ         /* @text: 6GHz */,
            };

    EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("StartWiFiScan"), 
-        _T("{\"frequency\":\"2.4GHz\"}"), response));
+        _T("{\"frequency\":[\"2.4\"]}"), response));
    EXPECT_EQ(response, _T("{\"success\":true}"));


    EXPECT_EQ(Core::ERROR_NONE, handler.Invoke(connection, _T("StartWiFiScan"), 
-        _T("{\"frequency\":\"2.4GHz\"}"), response));
+        _T("{\"frequency\":[\"2.4\"]}"), response));
    EXPECT_EQ(response, _T("{\"success\":false}"));


+            if (parameters.HasLabel("frequencies"))
+			{
+				JsonArray array = parameters["frequencies"].Array();
+                std::vector<std::string> frequencyList;
+	            JsonArray::Iterator index(array.Elements());


                string frequency = object["frequency"].String();

-
                double frequencyValue = std::stod(frequency);
                bool ssidMatches = scanForSsidsSet.empty() || scanForSsidsSet.find(ssid) != scanForSsidsSet.end();
-                bool freqMatches = m_filterfrequency.empty() || (filterFreq == frequencyValue);
+                bool freqMatches = m_filterFrequencies.empty();


jincysam87 added 13 commits April 22, 2026 22:44

Merge pull request #19 from rdkcentral/develop

594597f

Sync

Merge branch 'rdkcentral:develop' into develop

712c8e8

Merge branch 'rdkcentral:develop' into develop

1f5f624

Merge branch 'rdkcentral:develop' into develop

7a0e1f8

Update NetworkManagerGnomeProxy.cpp

1fd41f2

Update NetworkManagerGnomeWIFI.cpp

3e1b457

Update NetworkManagerGnomeWIFI.h

e0ed060

Update NetworkManagerGnomeWIFI.cpp

5448555

Update NetworkManagerImplementation.cpp

17d1c07

Update NetworkManagerImplementation.cpp

c79bae1

Update NetworkManagerImplementation.cpp

bb2d211

Update NetworkManagerImplementation.cpp

96e9296

Update NetworkManagerGnomeWIFI.cpp

3a19acc

Copilot AI review requested due to automatic review settings May 8, 2026 15:59

jincysam87 requested a review from a team as a code owner May 8, 2026 15:59

Copilot started reviewing on behalf of jincysam87 May 8, 2026 16:00 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Potential fix for pull request finding

ec5d3a2

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 8, 2026 16:05

Copilot started reviewing on behalf of jincysam87 May 8, 2026 16:06 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Potential fix for pull request finding

216fb46

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 8, 2026 16:13

Update NetworkManagerGnomeWIFI.cpp

3aba5bb

Copilot started reviewing on behalf of jincysam87 May 8, 2026 16:14 View session

Update NetworkManagerGnomeWIFI.h

7032c46

Updated jscon file

0cb18b0

Copilot AI review requested due to automatic review settings May 22, 2026 01:30

Copilot started reviewing on behalf of jincysam87 May 22, 2026 01:30 View session

Copilot AI reviewed May 22, 2026

View reviewed changes

Comment thread docs/NetworkManagerPlugin.md

Comment thread tests/l2Test/rdk/l2_test_rdkproxy.cpp

Comment thread plugin/gnome/NetworkManagerGnomeProxy.cpp

Updated docs

0516339

Updated

3af5cf7

Copilot AI review requested due to automatic review settings May 22, 2026 01:59

Copilot started reviewing on behalf of jincysam87 May 22, 2026 02:00 View session

Copilot AI reviewed May 22, 2026

View reviewed changes

Comment thread tests/l2Test/rdk/l2_test_rdkproxy.cpp

Comment thread plugin/rdk/NetworkManagerRDKProxy.cpp

Comment thread plugin/NetworkManagerImplementation.cpp

Comment thread plugin/NetworkManagerImplementation.cpp

Update NetworkManagerGnomeProxy.cpp

d97af8a

Update NetworkManagerGnomeProxy.cpp

42520a4

Copilot AI review requested due to automatic review settings May 22, 2026 20:44

Copilot started reviewing on behalf of jincysam87 May 22, 2026 20:44 View session

Copilot AI reviewed May 22, 2026

View reviewed changes

Comment thread tests/l2Test/rdk/l2_test_rdkproxy.cpp

Comment thread tests/l2Test/rdk/l2_test_rdkproxy.cpp

Comment thread plugin/NetworkManagerImplementation.h

Comment thread plugin/NetworkManagerJsonRpc.cpp

Comment thread plugin/gnome/NetworkManagerGnomeProxy.cpp

karuna2git previously approved these changes May 27, 2026

View reviewed changes

Update validate_pr_desc.yml

66f1632

jincysam87 dismissed karuna2git’s stale review via 66f1632 May 27, 2026 19:44

Update NetworkManagerGnomeWIFI.cpp

98a8d64

Copilot AI review requested due to automatic review settings May 27, 2026 19:47

Copilot started reviewing on behalf of jincysam87 May 27, 2026 19:47 View session

Update NetworkManagerGnomeWIFI.cpp

32dcc36

Copilot AI reviewed May 27, 2026

View reviewed changes

Conversation

jincysam87 commented May 8, 2026

Uh oh!

rdkcmf-jenkins commented May 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 8, 2026

Uh oh!

rdkcmf-jenkins commented May 8, 2026

Uh oh!

rdkcmf-jenkins commented May 22, 2026

Uh oh!

rdkcmf-jenkins commented May 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 22, 2026

Uh oh!

rdkcmf-jenkins commented May 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 22, 2026

Uh oh!

rdkcmf-jenkins commented May 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karuna2git left a comment

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins commented May 27, 2026

Uh oh!

rdkcmf-jenkins commented May 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants