fix: Removed conflict in type for create static method and made opts parameter optional (#313)

ocarlott · Ngo, Minh · web-flow · commit b285e3be0257 · 2020-03-22T17:20:47.000+01:00
Co-authored-by: Ngo, Minh &lt;Minh.Ngo@siriusxm.com&gt;
diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
@@ -19,7 +19,7 @@ class AsyncStorageFactory {
 
   static create<M = EmptyStorageModel>(
     storage: IStorageBackend,
-    opts: FactoryOptions | null = null,
+    opts?: FactoryOptions,
   ) {
     return new AsyncStorage<M, IStorageBackend<M>>(
       storage,
diff --git a/packages/core/types/index.d.ts b/packages/core/types/index.d.ts
@@ -13,7 +13,7 @@
 export default class AsyncStorageFactory {
   static create<M = EmptyStorageModel>(
     storage: IStorageBackend,
-    opts: FactoryOptions,
+    opts?: FactoryOptions,
   ): AsyncStorage<M, IStorageBackend<M>>;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`export default class AsyncStorageFactory {`
`14`	`14`	`static create<M = EmptyStorageModel>(`
`15`	`15`	`storage: IStorageBackend,`
`16`		`- opts: FactoryOptions,`
	`16`	`+ opts?: FactoryOptions,`
`17`	`17`	`): AsyncStorage<M, IStorageBackend<M>>;`
`18`	`18`	`}`
`19`	`19`