Skip to content

Commit 07a6e1f

Browse files
coadometa-codesync[bot]
authored andcommitted
Cover react/renderer/css with Stable API guards (#58387)
Summary: Pull Request resolved: #58387 Classify the renderer CSS module as part of React Native’s public C++ stable API. Consumers opting into strict API checks must use the new <React/CSS.h> umbrella, while React Native’s own sources can continue using fine-grained includes. Changelog: [Internal] - Add <React/CSS.h> as the public entry point for renderer CSS APIs Reviewed By: cortinico Differential Revision: D119072734 fbshipit-source-id: e69339fbd81cd1a6f3bc240d42c7010f1f2884cd
1 parent d6a5f15 commit 07a6e1f

32 files changed

Lines changed: 146 additions & 4 deletions

packages/react-native/ReactAndroid/build.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ val preparePrefab by
142142
Pair("../ReactCommon/react/renderer/core/", "react/renderer/core/"),
143143
// react_renderer_css
144144
Pair("../ReactCommon/react/renderer/css/", "react/renderer/css/"),
145+
Pair("../ReactCommon/react/renderer/css/React/", "React/"),
145146
// react_debug
146147
Pair("../ReactCommon/react/debug/", "react/debug/"),
147148
Pair("../ReactCommon/react/debug/React/", "React/"),

packages/react-native/ReactCommon/react/renderer/css/CMakeLists.txt

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,27 @@ file(GLOB react_renderer_css_SRC CONFIGURE_DEPENDS *.cpp)
1414
if("${react_renderer_css_SRC}" STREQUAL "")
1515
add_library(react_renderer_css INTERFACE)
1616

17-
target_include_directories(react_renderer_css INTERFACE ${REACT_COMMON_DIR})
17+
target_include_directories(react_renderer_css INTERFACE
18+
${REACT_COMMON_DIR}
19+
${CMAKE_CURRENT_SOURCE_DIR})
1820
target_link_libraries(react_renderer_css INTERFACE
1921
fast_float
2022
glog
23+
react_cxxstableapi
2124
react_debug
2225
react_utils)
2326
target_compile_reactnative_options(react_renderer_css INTERFACE)
2427
target_compile_options(react_renderer_css INTERFACE -Wpedantic)
2528
else()
2629
add_library(react_renderer_css OBJECT ${react_renderer_css_SRC})
2730

28-
target_include_directories(react_renderer_css PUBLIC ${REACT_COMMON_DIR})
31+
target_include_directories(react_renderer_css PUBLIC
32+
${REACT_COMMON_DIR}
33+
${CMAKE_CURRENT_SOURCE_DIR})
2934
target_link_libraries(react_renderer_css
3035
fast_float
3136
glog
37+
react_cxxstableapi
3238
react_debug
3339
react_utils)
3440
target_compile_reactnative_options(react_renderer_css PRIVATE)

packages/react-native/ReactCommon/react/renderer/css/CSSAngle.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <optional>
1113

1214
#include <react/renderer/css/CSSAngleUnit.h>

packages/react-native/ReactCommon/react/renderer/css/CSSAngleUnit.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <cmath>
1113
#include <cstdint>
1214
#include <optional>

packages/react-native/ReactCommon/react/renderer/css/CSSBackgroundImage.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <optional>
1113
#include <variant>
1214

packages/react-native/ReactCommon/react/renderer/css/CSSColor.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <optional>
1113

1214
#include <react/renderer/css/CSSColorFunction.h>

packages/react-native/ReactCommon/react/renderer/css/CSSColorFunction.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <algorithm>
1113
#include <cmath>
1214
#include <cstdint>

packages/react-native/ReactCommon/react/renderer/css/CSSCompoundDataType.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <react/renderer/css/CSSDataType.h>
1113

1214
namespace facebook::react {

packages/react-native/ReactCommon/react/renderer/css/CSSDataType.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <any>
1113
#include <concepts>
1214
#include <optional>

packages/react-native/ReactCommon/react/renderer/css/CSSFilter.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/UmbrellaGuard.h>
11+
1012
#include <array>
1113
#include <optional>
1214
#include <variant>

0 commit comments

Comments
 (0)