Skip to content

Commit 9c770f5

Browse files
cortinicometa-codesync[bot]
authored andcommitted
Fix Maestro Cloud project ID reference (#57943)
Summary: - read the Maestro Cloud project ID from the repository secret in both iOS and Android jobs - match the existing repository configuration and unblock input validation The failing main run resolved vars.MAESTRO_CLOUD_PROJECT_ID to an empty string because MAESTRO_CLOUD_PROJECT_ID is configured as a GitHub Actions secret. Changelog: [Internal] [Changed] - Pull Request resolved: #57943 Test Plan: - node_modules/.bin/prettier --check .github/workflows/test-all.yml - git diff --check Reviewed By: huntie Differential Revision: D115871650 Pulled By: cortinico fbshipit-source-id: f7475fa8fcd30e334b9bf3d361f6f718bd0ca7e4
1 parent b80bc19 commit 9c770f5

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/test-all.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ jobs:
190190
- name: Validate Maestro Cloud inputs
191191
env:
192192
MAESTRO_CLOUD_API_KEY: ${{ secrets.MAESTRO_CLOUD_API_KEY }}
193-
MAESTRO_CLOUD_PROJECT_ID: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }}
193+
MAESTRO_CLOUD_PROJECT_ID: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }}
194194
run: |
195195
test -n "$MAESTRO_CLOUD_API_KEY"
196196
test -n "$MAESTRO_CLOUD_PROJECT_ID"
@@ -200,7 +200,7 @@ jobs:
200200
uses: mobile-dev-inc/action-maestro-cloud@5759506b4ec7ee0a1ece4b7e6574bba2b282f241 # v3.0.1
201201
with:
202202
api-key: ${{ secrets.MAESTRO_CLOUD_API_KEY }}
203-
project-id: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }}
203+
project-id: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }}
204204
app-file: /tmp/RNTesterBuild/RNTester.app
205205
workspace: packages/rn-tester/.maestro
206206
branch: ${{ github.head_ref || github.ref_name }}
@@ -402,7 +402,7 @@ jobs:
402402
- name: Validate Maestro Cloud inputs
403403
env:
404404
MAESTRO_CLOUD_API_KEY: ${{ secrets.MAESTRO_CLOUD_API_KEY }}
405-
MAESTRO_CLOUD_PROJECT_ID: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }}
405+
MAESTRO_CLOUD_PROJECT_ID: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }}
406406
run: |
407407
test -n "$MAESTRO_CLOUD_API_KEY"
408408
test -n "$MAESTRO_CLOUD_PROJECT_ID"
@@ -412,7 +412,7 @@ jobs:
412412
uses: mobile-dev-inc/action-maestro-cloud@5759506b4ec7ee0a1ece4b7e6574bba2b282f241 # v3.0.1
413413
with:
414414
api-key: ${{ secrets.MAESTRO_CLOUD_API_KEY }}
415-
project-id: ${{ vars.MAESTRO_CLOUD_PROJECT_ID }}
415+
project-id: ${{ secrets.MAESTRO_CLOUD_PROJECT_ID }}
416416
app-file: /tmp/rntester-android/app-x86-release.apk
417417
workspace: packages/rn-tester/.maestro
418418
branch: ${{ github.head_ref || github.ref_name }}

0 commit comments

Comments
 (0)