Skip to content

Commit bc64b26

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Cover react/renderer/consistency:consistency with Stable API guards (#58046)
Summary: Pull Request resolved: #58046 Classifies `react/renderer/consistency:consistency` as a private target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/PrivateGuard.h>` to both headers in the module and declares the guard dependency in BUCK, CMake and the podspec. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D116601683 fbshipit-source-id: 51d9e197dc44396f60f6349d853b0a48d00f50d0
1 parent f2d6596 commit bc64b26

4 files changed

Lines changed: 8 additions & 0 deletions

File tree

packages/react-native/ReactCommon/react/renderer/consistency/CMakeLists.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,7 @@ file(GLOB react_renderer_consistency_SRC CONFIGURE_DEPENDS *.cpp)
1212
add_library(react_renderer_consistency OBJECT ${react_renderer_consistency_SRC})
1313

1414
target_include_directories(react_renderer_consistency PUBLIC ${REACT_COMMON_DIR})
15+
16+
target_link_libraries(react_renderer_consistency react_cxxstableapi)
1517
target_compile_reactnative_options(react_renderer_consistency PRIVATE)
1618
target_compile_options(react_renderer_consistency PRIVATE -Wpedantic)

packages/react-native/ReactCommon/react/renderer/consistency/React-rendererconsistency.podspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,5 +40,7 @@ Pod::Spec.new do |s|
4040

4141
resolve_use_frameworks(s, header_mappings_dir: "../../..", module_name: "React_rendererconsistency")
4242

43+
s.dependency "React-cxxstableapi"
44+
4345
mark_as_react_native_build(s)
4446
end

packages/react-native/ReactCommon/react/renderer/consistency/ScopedShadowTreeRevisionLock.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
#include <react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h>
1113

1214
namespace facebook::react {

packages/react-native/ReactCommon/react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77

88
#pragma once
99

10+
#include <react/cxxstableapi/PrivateGuard.h>
11+
1012
namespace facebook::react {
1113

1214
/**

0 commit comments

Comments
 (0)