Skip to content

Commit d064ec2

Browse files
j-piaseckimeta-codesync[bot]
authored andcommitted
Upgrade Text visibility to "for frameworks" (#58284)
Summary: Pull Request resolved: #58284 Reclassifies `react/renderer/components/text:text` from public to "for frameworks" under the C++ stable API three-tier visibility model. Consumers that opt into `RN_STRICT_API` now get a suppressible warning where they previously got an error pointing at the umbrella, and can acknowledge it with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D118440348
1 parent b19653f commit d064ec2

30 files changed

Lines changed: 26 additions & 101 deletions

packages/react-native/ReactAndroid/build.gradle.kts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -201,10 +201,6 @@ val preparePrefab by
201201
"../ReactCommon/react/renderer/components/text/",
202202
"react/renderer/components/text/",
203203
),
204-
Pair(
205-
"../ReactCommon/react/renderer/components/text/React/",
206-
"React/",
207-
),
208204
Pair("../ReactCommon/react/renderer/components/text/platform/android/", ""),
209205
Pair(
210206
"../ReactCommon/react/renderer/attributedstring",

packages/react-native/ReactCommon/React-FabricComponents.podspec

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -110,12 +110,6 @@ Pod::Spec.new do |s|
110110
sss.header_dir = "react/renderer/components/text"
111111
end
112112

113-
ss.subspec "textUmbrella" do |sss|
114-
sss.source_files = "react/renderer/components/text/React/*.h"
115-
sss.header_dir = ""
116-
sss.header_mappings_dir = "react/renderer/components/text"
117-
end
118-
119113
ss.subspec "iostextinput" do |sss|
120114
sss.source_files = podspec_sources(["react/renderer/components/textinput/*.{m,mm,cpp,h}",
121115
"react/renderer/components/textinput/platform/ios/**/*.{m,mm,cpp,h}"],

packages/react-native/ReactCommon/react/renderer/components/text/BaseParagraphComponentDescriptor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/core/ConcreteComponentDescriptor.h>
1313
#include <react/renderer/textlayoutmanager/TextLayoutManager.h>

packages/react-native/ReactCommon/react/renderer/components/text/BaseParagraphProps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <limits>
1313
#include <memory>

packages/react-native/ReactCommon/react/renderer/components/text/BaseTextProps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/attributedstring/TextAttributes.h>
1313
#include <react/renderer/core/Props.h>

packages/react-native/ReactCommon/react/renderer/components/text/BaseTextShadowNode.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/attributedstring/AttributedString.h>
1313
#include <react/renderer/attributedstring/TextAttributes.h>

packages/react-native/ReactCommon/react/renderer/components/text/ParagraphComponentDescriptor.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/components/text/BaseParagraphComponentDescriptor.h>
1313
#include <react/renderer/components/text/ParagraphShadowNode.h>

packages/react-native/ReactCommon/react/renderer/components/text/ParagraphEventEmitter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/components/view/ViewEventEmitter.h>
1313
#include <react/renderer/textlayoutmanager/TextMeasureCache.h>

packages/react-native/ReactCommon/react/renderer/components/text/ParagraphProps.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/components/text/HostPlatformParagraphProps.h>
1313

packages/react-native/ReactCommon/react/renderer/components/text/ParagraphShadowNode.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#pragma once
99

10-
#include <react/cxxstableapi/UmbrellaGuard.h>
10+
#include <react/cxxstableapi/FrameworksGuard.h>
1111

1212
#include <react/renderer/components/text/BaseTextShadowNode.h>
1313
#include <react/renderer/components/text/ParagraphEventEmitter.h>

0 commit comments

Comments
 (0)