Fix native component event property checks - #58195
Closed
OskarEichler wants to merge 1 commit into
Closed
OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
OskarEichler
force-pushed
the
fix/native-component-event-own-check
branch
from
August 30, 2026 07:59
08dc8ad to
981b94b
Compare
OskarEichler
force-pushed
the
fix/native-component-event-own-check
branch
from
August 30, 2026 08:05
981b94b to
9e9daef
Compare
|
@vzaidman has imported this pull request. If you are a Meta employee, you can view this in D120117546. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Legacy native component event merging invokes
hasOwnPropertydirectly on native/default event maps. An own event namedhasOwnPropertyshadows that method and crashes component initialization. Use a bound intrinsic own-property check for both source and destination maps, and add an exact regression.Hosted Flow caught two stale-server misses in the first patches: method unbinding/exact-object inference, then the deprecated
mixedannotation. The final head uses the repository-standard suppression around the captured intrinsic and an explicitunknownindexer for the mutable test map.Fixes #58194.
Changelog:
[GENERAL] [FIXED] - Handle native component event names that shadow Object prototype properties.
Test Plan:
getNativeComponentAttributesJest suite: 2 tests passed on the original regression/fix run.git diff --checkpassed.No UI change; screenshots are not applicable.