Layout breaks when the first element has a different minWidth than the rest - #58395
Open
pasqualeanatriello wants to merge 1 commit into
Open
Layout breaks when the first element has a different minWidth than the rest#58395pasqualeanatriello wants to merge 1 commit into
pasqualeanatriello wants to merge 1 commit into
Conversation
…e rest Summary: fixes react/yoga#2006 `distributeFreeSpaceFirstPass` decrements `totalFlexGrowFactors` / `totalFlexShrinkScaledFactors` as it freezes items, but only reduces `remainingFreeSpace` after the loop. Items after the first frozen one get an inflated fair share and freeze spuriously. When the first item clamps, the whole line freezes and `remainingFreeSpace` drains to 0, so the second pass has nothing to distribute and everything falls back to its flex basis — a 540px row of three `flexGrow: 1` items with `maxWidth: 180` and minWidths 60/30/30 lays out as 60/30/30 instead of 180/180/180. Snapshot both totals before the loop and divide by the snapshot. The first pass is then iteration 1 of CSS Flexbox §9.7, and independent of child order. Changelog: [General][Fixed] - Fix a flex line collapsing to its minimum sizes when the first item clamps to its min or max main size X-link: react/yoga#2021 Reviewed By: javache Differential Revision: D119142409 Pulled By: pasqualeanatriello
meta-cla
Bot
added
the
CLA Signed
|
@pasqualeanatriello has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119142409. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
fixes react/yoga#2006
distributeFreeSpaceFirstPassdecrementstotalFlexGrowFactors/totalFlexShrinkScaledFactorsas it freezes items, but only reducesremainingFreeSpaceafter the loop. Items after the first frozen one get an inflated fair share and freeze
spuriously. When the first item clamps, the whole line freezes and
remainingFreeSpacedrains to 0, so the second pass has nothing to distribute and everything falls back to its
flex basis — a 540px row of three
flexGrow: 1items withmaxWidth: 180and minWidths60/30/30 lays out as 60/30/30 instead of 180/180/180.
Snapshot both totals before the loop and divide by the snapshot. The first pass is then
iteration 1 of CSS Flexbox §9.7, and independent of child order.
Changelog:
[General][Fixed] - Fix a flex line collapsing to its minimum sizes when the first item clamps to its min or max main size
X-link: react/yoga#2021
Reviewed By: javache
Differential Revision: D119142409
Pulled By: pasqualeanatriello