From 820f3e9662e15bad90848d0627d2fd2fc879bb95 Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Mon, 7 Sep 2026 00:50:33 -0700 Subject: [PATCH] Cover `react/renderer/consistency:consistency` with Stable API guards Summary: Classifies `react/renderer/consistency:consistency` as a private target under the C++ stable API three-tier visibility model. Adds `#include ` to both headers in the module and declares the guard dependency in BUCK, CMake and the podspec. Changelog: [Internal] Differential Revision: D116601683 --- .../ReactCommon/react/renderer/consistency/CMakeLists.txt | 2 ++ .../renderer/consistency/React-rendererconsistency.podspec | 2 ++ .../react/renderer/consistency/ScopedShadowTreeRevisionLock.h | 2 ++ .../renderer/consistency/ShadowTreeRevisionConsistencyManager.h | 2 ++ 4 files changed, 8 insertions(+) diff --git a/packages/react-native/ReactCommon/react/renderer/consistency/CMakeLists.txt b/packages/react-native/ReactCommon/react/renderer/consistency/CMakeLists.txt index 9f42cf6f800c..2d2dbf5fa202 100644 --- a/packages/react-native/ReactCommon/react/renderer/consistency/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/renderer/consistency/CMakeLists.txt @@ -12,5 +12,7 @@ file(GLOB react_renderer_consistency_SRC CONFIGURE_DEPENDS *.cpp) add_library(react_renderer_consistency OBJECT ${react_renderer_consistency_SRC}) target_include_directories(react_renderer_consistency PUBLIC ${REACT_COMMON_DIR}) + +target_link_libraries(react_renderer_consistency react_cxxstableapi) target_compile_reactnative_options(react_renderer_consistency PRIVATE) target_compile_options(react_renderer_consistency PRIVATE -Wpedantic) diff --git a/packages/react-native/ReactCommon/react/renderer/consistency/React-rendererconsistency.podspec b/packages/react-native/ReactCommon/react/renderer/consistency/React-rendererconsistency.podspec index e4cf09b0d814..7fa840edb962 100644 --- a/packages/react-native/ReactCommon/react/renderer/consistency/React-rendererconsistency.podspec +++ b/packages/react-native/ReactCommon/react/renderer/consistency/React-rendererconsistency.podspec @@ -40,5 +40,7 @@ Pod::Spec.new do |s| resolve_use_frameworks(s, header_mappings_dir: "../../..", module_name: "React_rendererconsistency") + s.dependency "React-cxxstableapi" + mark_as_react_native_build(s) end diff --git a/packages/react-native/ReactCommon/react/renderer/consistency/ScopedShadowTreeRevisionLock.h b/packages/react-native/ReactCommon/react/renderer/consistency/ScopedShadowTreeRevisionLock.h index 51df90e7f261..66c35d8ad40d 100644 --- a/packages/react-native/ReactCommon/react/renderer/consistency/ScopedShadowTreeRevisionLock.h +++ b/packages/react-native/ReactCommon/react/renderer/consistency/ScopedShadowTreeRevisionLock.h @@ -7,6 +7,8 @@ #pragma once +#include + #include namespace facebook::react { diff --git a/packages/react-native/ReactCommon/react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h b/packages/react-native/ReactCommon/react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h index d5afba016f64..6896b74a2b03 100644 --- a/packages/react-native/ReactCommon/react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h +++ b/packages/react-native/ReactCommon/react/renderer/consistency/ShadowTreeRevisionConsistencyManager.h @@ -7,6 +7,8 @@ #pragma once +#include + namespace facebook::react { /**