[RN] Move RN globals to RN private interface module (#37550)

## Summary

ReactNativeFeatureFlags and fabricUIManager were introduced in
`react-native/react-private-interface` in
react/react-native#57940 and
react/react-native#58398:


https://github.com/react/react-native/blob/73a76ddced2088d925809432fd6b0503f239dbfe/packages/react-native/src/react-private-interface.js#L74


https://github.com/react/react-native/blob/73a76ddced2088d925809432fd6b0503f239dbfe/packages/react-native/src/react-private-interface.js#L87

This migrates the use of globals for those bindings to use the exported
values instead.

## How did you test this change?

Existing tests and Flow.

Author: rubennorte

.eslintrc.js

@@ -458,13 +458,6 @@ module.exports = {
         'eslint-plugin/require-meta-has-suggestions': ERROR,
       },
     },
-    {
-      files: ['packages/react-native-renderer/**/*.js'],
-      globals: {
-        nativeFabricUIManager: 'readonly',
-        RN$isNativeEventTargetEventDispatchingEnabled: 'readonly',
-      },
-    },
     {
       files: ['packages/react-server-dom-webpack/**/*.js'],
       globals: {

packages/react-native-renderer/src/ReactFabricGlobalResponderHandler.js

@@ -7,11 +7,14 @@
  * @flow
  */
 
+// Modules provided by RN:
+import {fabricUIManager} from 'react-native/react-private-interface';
+
 const ReactFabricGlobalResponderHandler = {
   onChange: function (from: any, to: any, blockNativeResponder: boolean) {
     if (from && from.stateNode) {
       // equivalent to clearJSResponder
-      nativeFabricUIManager.setIsJSResponder(
+      fabricUIManager.setIsJSResponder(
         from.stateNode.node,
         false,
         blockNativeResponder || false,
@@ -20,7 +23,7 @@ const ReactFabricGlobalResponderHandler = {
 
     if (to && to.stateNode) {
       // equivalent to setJSResponder
-      nativeFabricUIManager.setIsJSResponder(
+      fabricUIManager.setIsJSResponder(
         to.stateNode.node,
         true,
         blockNativeResponder || false,

packages/react-native-renderer/src/ReactFiberConfigFabric.js

@@ -36,6 +36,7 @@ import {
   createPublicTextInstance,
   createAttributePayload,
   diffAttributePayloads,
+  fabricUIManager,
   type PublicInstance as ReactNativePublicInstance,
   type PublicTextInstance,
   type PublicRootInstance,
@@ -61,7 +62,7 @@ const {
   unstable_IdleEventPriority: FabricIdlePriority,
   unstable_getCurrentEventPriority: fabricGetCurrentEventPriority,
   suspendOnActiveViewTransition: fabricSuspendOnActiveViewTransition,
-} = nativeFabricUIManager;
+} = fabricUIManager;
 
 import {getClosestInstanceFromNode} from './ReactFabricComponentTree';
 import {compareDocumentPositionForEmptyFragment} from 'shared/ReactDOMFragmentRefShared';

packages/react-native-renderer/src/ReactFiberConfigFabricWithViewTransition.js

@@ -18,12 +18,15 @@ import type {
 
 import {allocateTag} from './ReactFiberConfigFabric';
 
+// Modules provided by RN:
+import {fabricUIManager} from 'react-native/react-private-interface';
+
 const {
   applyViewTransitionName: fabricApplyViewTransitionName,
   createViewTransitionInstance: fabricCreateViewTransitionInstance,
   startViewTransition: fabricStartViewTransition,
   startViewTransitionReadyFinished: fabricStartViewTransitionReadyFinished,
-} = nativeFabricUIManager;
+} = fabricUIManager;
 
 export type InstanceMeasurement = {
   rect: {x: number, y: number, width: number, height: number},

packages/react-native-renderer/src/ReactNativeFeatureFlags.js

@@ -7,17 +7,23 @@
  * @flow
  */
 
-// These globals are set by React Native (e.g. in setUpDOM.js, setUpTimers.js)
-// and provide access to RN's feature flags. We use global functions because we
-// don't have another mechanism to pass feature flags from RN to React in OSS.
+// Modules provided by RN:
+import {ReactNativeFeatureFlags} from 'react-native/react-private-interface';
+
+// These accessors are provided by React Native and give us access to RN's
+// feature flags. Both the object and each accessor on it are treated as
+// optional so that removing a flag on the React Native side doesn't throw here.
 // Values are lazily evaluated and cached on first access.
 
 let _enableNativeEventTargetEventDispatching: boolean | null = null;
 export function enableNativeEventTargetEventDispatching(): boolean {
   if (_enableNativeEventTargetEventDispatching == null) {
+    const isEnabled =
+      ReactNativeFeatureFlags != null
+        ? ReactNativeFeatureFlags.enableNativeEventTargetEventDispatching
+        : null;
     _enableNativeEventTargetEventDispatching =
-      typeof RN$isNativeEventTargetEventDispatchingEnabled === 'function' &&
-      RN$isNativeEventTargetEventDispatchingEnabled();
+      typeof isEnabled === 'function' && isEnabled();
   }
   return _enableNativeEventTargetEventDispatching;
 }

packages/react-native-renderer/src/ReactNativeFiberInspector.js

@@ -16,8 +16,11 @@ import {
 } from 'react-reconciler/src/ReactFiberTreeReflection';
 import getComponentNameFromType from 'shared/getComponentNameFromType';
 import {HostComponent} from 'react-reconciler/src/ReactWorkTags';
-// Module provided by RN:
-import {getNodeFromPublicInstance} from 'react-native/react-private-interface';
+// Modules provided by RN:
+import {
+  getNodeFromPublicInstance,
+  fabricUIManager,
+} from 'react-native/react-private-interface';
 import {getNodeFromInternalInstanceHandle} from './ReactNativePublicCompat';
 import {getStackByFiberInDevAndProd} from 'react-reconciler/src/ReactFiberComponentStack';
 
@@ -43,7 +46,7 @@ if (__DEV__) {
               hostFiber.stateNode.node;
 
             if (node) {
-              nativeFabricUIManager.measure(node, callback);
+              fabricUIManager.measure(node, callback);
             }
           },
         };
@@ -142,7 +145,7 @@ function getInspectorDataForViewAtPoint(
     const fabricNode = getNodeFromPublicInstance(inspectedView);
     if (fabricNode) {
       // For Fabric we can look up the instance handle directly and measure it.
-      nativeFabricUIManager.findNodeAtPoint(
+      fabricUIManager.findNodeAtPoint(
         fabricNode,
         locationX,
         locationY,
@@ -169,20 +172,16 @@ function getInspectorDataForViewAtPoint(
           const nativeViewTag =
             internalInstanceHandle.stateNode.canonical.nativeTag;
 
-          nativeFabricUIManager.measure(
-            node,
-            (x, y, width, height, pageX, pageY) => {
-              const inspectorData =
-                getInspectorDataForInstance(closestInstance);
-              callback({
-                ...inspectorData,
-                pointerY: locationY,
-                frame: {left: pageX, top: pageY, width, height},
-                touchedViewTag: nativeViewTag,
-                closestPublicInstance,
-              });
-            },
-          );
+          fabricUIManager.measure(node, (x, y, width, height, pageX, pageY) => {
+            const inspectorData = getInspectorDataForInstance(closestInstance);
+            callback({
+              ...inspectorData,
+              pointerY: locationY,
+              frame: {left: pageX, top: pageY, width, height},
+              touchedViewTag: nativeViewTag,
+              closestPublicInstance,
+            });
+          });
         },
       );
     } else {

packages/react-native-renderer/src/ReactNativePublicCompat.js

@@ -16,6 +16,7 @@ import {
   getNodeFromPublicInstance,
   getNativeTagFromPublicInstance,
   getInternalInstanceHandleFromPublicInstance,
+  fabricUIManager,
 } from 'react-native/react-private-interface';
 
 import {
@@ -148,7 +149,7 @@ export function dispatchCommand(
   const node = getNodeFromPublicInstance(handle);
 
   if (node != null) {
-    nativeFabricUIManager.dispatchCommand(node, command, args);
+    fabricUIManager.dispatchCommand(node, command, args);
   } else {
     if (__DEV__) {
       console.error(
@@ -163,7 +164,7 @@ export function sendAccessibilityEvent(handle: any, eventType: string) {
   const node = getNodeFromPublicInstance(handle);
 
   if (node != null) {
-    nativeFabricUIManager.sendAccessibilityEvent(node, eventType);
+    fabricUIManager.sendAccessibilityEvent(node, eventType);
   } else {
     if (__DEV__) {
       console.error(

packages/react-native-renderer/src/__mocks__/react-native/Libraries/ReactPrivate/ReactNativeFeatureFlags.js

@@ -0,0 +1,14 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow strict-local
+ */
+
+module.exports = {
+  enableNativeEventTargetEventDispatching(): boolean {
+    return false;
+  },
+};

packages/react-native-renderer/src/__mocks__/react-native/Libraries/ReactPrivate/ReactNativePrivateInterface.js

@@ -8,9 +8,15 @@
  */
 
 module.exports = {
+  get fabricUIManager() {
+    return global.nativeFabricUIManager;
+  },
   get ReactFiberErrorDialog() {
     return require('./ReactFiberErrorDialog');
   },
+  get ReactNativeFeatureFlags() {
+    return require('./ReactNativeFeatureFlags');
+  },
   get ReactNativeViewConfigRegistry() {
     return require('./ReactNativeViewConfigRegistry');
   },