feat: support kinetic #90
Conversation
Signed-off-by: Brian Nguyen <[email protected]>
Signed-off-by: Brian Nguyen <[email protected]>
Signed-off-by: Brian Nguyen <[email protected]>
Signed-off-by: Brian Nguyen <[email protected]>
tedraykov
left a comment
tedraykov
left a comment
There was a problem hiding this comment.
Looks good to me. We should discuss how we could update Kinetic because it differs from the API. The API project entirely relies on external packages and we can easily diff them. When it comes to Kinetic, all components are part of the project's source code.
A solution I can think of is to structure the project as a monorepo and each UI module (orders, products, navigation) to be a separate package, that can be updated. The packages won't have to be published but we can leverage pnpm's workspaces https://pnpm.io/workspaces
That way we can differentiate each package against the upstream package and pull the changes accordingly.
|
@vanpho93 Now that Kinetic is public, we can probably just resolve these conflict and merge this |
brent-hoover
left a comment
brent-hoover
left a comment
There was a problem hiding this comment.
Just one doc change
| ``` | ||
| For more information about developing the admin you can go to [Mailchimp Open Commerce Documentation](https://mailchimp.com/developer/open-commerce/) | ||
|
|
||
| ## Adding the Kinetic |
There was a problem hiding this comment.
Should probably drop the "the" here. It's just Kinetic
Signed-off-by: Brian Nguyen [email protected]
Resolves: #86
Testing
reaction create-project kinetic kinetic && cd kinetic && pnpm install && reaction develop