Ensure attribute exists before accessing it. (#12557)

ericholscher · web-flow · commit 6ac9d75d6370 · 2025-11-06T10:09:08.000-08:00
Also adds tests to ensure this works, and doesn't blow up. Fixes https://read-the-docs.sentry.io/issues/4262263207
diff --git a/readthedocs/embed/tests/test_links.py b/readthedocs/embed/tests/test_links.py
@@ -149,3 +149,19 @@ def test_two_links():
         firsturl.expected,
         secondurl.expected,
     )
+
+
+def test_missing_href_attribute():
+    """Test that links without href attribute don't cause errors."""
+    pq = PyQuery('<body><a>Link without href</a></body>')
+    response = clean_references(pq, html_base_url)
+    # Should not raise KeyError, just skip the link
+    assert response.find("a") is not None
+
+
+def test_missing_src_attribute():
+    """Test that images without src attribute don't cause errors."""
+    pq = PyQuery('<body><img alt="image without src"></img></body>')
+    response = clean_references(pq, html_base_url)
+    # Should not raise KeyError, just skip the image
+    assert response.find("img") is not None
diff --git a/readthedocs/embed/utils.py b/readthedocs/embed/utils.py
@@ -34,6 +34,11 @@ def clean_references(obj, url, html_raw_response=False):
     for tag in obj.find("a") + obj.find("img"):
         base_url = urlparse(url)
         attribute = "href" if tag.tag == "a" else "src"
+
+        # Skip if the attribute doesn't exist
+        if attribute not in tag.attrib:
+            continue
+
         value = tag.attrib[attribute]
 
         # We need to make all internal links/images, to be absolute
