refactor: replace InvalidArgumentException with BizException for validation errors

Author: aspirantzhang

contexts/ArticlePublishing/Tests/Unit/Domain/Models/ArticleIdTest.php

@@ -1,6 +1,7 @@
 <?php
 
 declare(strict_types=1);
+use App\Exceptions\BizException;
 use Contexts\ArticlePublishing\Domain\Models\ArticleId;
 
 it('can be created', function (int $validId) {
@@ -10,7 +11,7 @@
 })->with([1, 100]);
 
 it('throws an exception when the ID is invalid', function (int $invalidId) {
-    $this->expectException(\InvalidArgumentException::class);
+    $this->expectException(BizException::class);
 
     ArticleId::fromInt($invalidId);
 })->with([-1, -100]);

contexts/Authorization/Domain/UserIdentity/Models/Email.php

@@ -4,12 +4,15 @@
 
 namespace Contexts\Authorization\Domain\UserIdentity\Models;
 
+use App\Exceptions\BizException;
+
 class Email
 {
     public function __construct(private string $value)
     {
         if (! filter_var($value, FILTER_VALIDATE_EMAIL)) {
-            throw new \InvalidArgumentException('Invalid email address');
+            throw BizException::make('Invalid email address: :email')
+                ->with('email', $value);
         }
     }
 

contexts/Authorization/Domain/UserIdentity/Models/Password.php

@@ -4,14 +4,16 @@
 
 namespace Contexts\Authorization\Domain\UserIdentity\Models;
 
+use App\Exceptions\BizException;
+
 class Password
 {
     private function __construct(private string $hashedValue) {}
 
     public static function createFromPlainText(string $plainText): self
     {
         if (strlen($plainText) < 8) {
-            throw new \InvalidArgumentException('Password must be at least 8 characters long');
+            throw BizException::make('Password must be at least 8 characters long');
         }
 
         return new self(password_hash($plainText, PASSWORD_ARGON2ID));

contexts/Authorization/Tests/Unit/Domain/UserIdentity/Models/EmailTest.php

@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use App\Exceptions\BizException;
 use Contexts\Authorization\Domain\UserIdentity\Models\Email;
 
 it('can be created with valid email address', function (string $validEmail) {
@@ -19,7 +20,7 @@
 it('throws an exception when email address is invalid', function (string $invalidEmail) {
     expect(function () use ($invalidEmail) {
         new Email($invalidEmail);
-    })->toThrow(InvalidArgumentException::class, 'Invalid email address');
+    })->toThrow(BizException::class, 'Invalid email address');
 })->with([
     'not-an-email',
     'missing@domain',

contexts/Authorization/Tests/Unit/Domain/UserIdentity/Models/PasswordTest.php

@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use App\Exceptions\BizException;
 use Contexts\Authorization\Domain\UserIdentity\Models\Password;
 
 it('can create a password from plain text', function () {
@@ -21,7 +22,7 @@
 it('throws an exception when password is too short', function (string $shortPassword) {
     expect(function () use ($shortPassword) {
         Password::createFromPlainText($shortPassword);
-    })->toThrow(InvalidArgumentException::class, 'Password must be at least 8 characters long');
+    })->toThrow(BizException::class, 'Password must be at least 8 characters long');
 })->with(['abc', 'short', '1234567']);
 
 it('verifies a correct password', function () {

contexts/Authorization/Tests/Unit/Domain/UserIdentity/Models/UserIdentityTest.php

@@ -352,13 +352,13 @@
 });
 
 it('validates email format', function () {
-    expect(fn () => new Email('invalid-email'))->toThrow(\InvalidArgumentException::class);
-    expect(fn () => new Email('[email protected]'))->not->toThrow(\InvalidArgumentException::class);
+    expect(fn () => new Email('invalid-email'))->toThrow(BizException::class);
+    expect(fn () => new Email('[email protected]'))->not->toThrow(BizException::class);
 });
 
 it('validates password minimum length', function () {
-    expect(fn () => Password::createFromPlainText('short'))->toThrow(\InvalidArgumentException::class);
-    expect(fn () => Password::createFromPlainText('password12345'))->not->toThrow(\InvalidArgumentException::class);
+    expect(fn () => Password::createFromPlainText('short'))->toThrow(BizException::class);
+    expect(fn () => Password::createFromPlainText('password12345'))->not->toThrow(BizException::class);
 });
 
 it('can get user summary for logging', function () {

contexts/Shared/ValueObjects/IntId.php

@@ -4,12 +4,15 @@
 
 namespace Contexts\Shared\ValueObjects;
 
+use App\Exceptions\BizException;
+
 abstract class IntId
 {
     final private function __construct(private readonly int $value)
     {
         if ($value < 0) {
-            throw new \InvalidArgumentException('Invalid ID value');
+            throw BizException::make('Invalid ID value :value')
+                ->with('value', $value);
         }
     }
 

tests/Unit/Shared/ValueObjects/IntIdTest.php

@@ -2,6 +2,7 @@
 
 declare(strict_types=1);
 
+use App\Exceptions\BizException;
 use Contexts\Shared\ValueObjects\IntId;
 
 // Create a concrete implementation of the abstract IntId class for testing
@@ -15,7 +16,7 @@ class ConcreteIntId extends IntId {}
 
 it('throws exception when created with negative value', function (int $invalidId) {
     expect(fn () => ConcreteIntId::fromInt($invalidId))
-        ->toThrow(\InvalidArgumentException::class, 'Invalid ID value');
+        ->toThrow(BizException::class, 'Invalid ID value');
 })->with([-1, -100, PHP_INT_MIN]);
 
 it('can create a null ID', function () {