Skip to content

Commit 347973d

Browse files
authored
Merge pull request #57 from redhat-performance/remove_pbench_support
Remove pbench support
2 parents 287781f + b5cb4dd commit 347973d

File tree

2 files changed

+9
-37
lines changed

2 files changed

+9
-37
lines changed

README.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ General options
2222
--home_parent <value>: Our parent home directory. If not set, defaults to current working directory.
2323
--host_config <value>: default is the current host name.
2424
--iterations <value>: Number of times to run the test, defaults to 1.
25-
--pbench: use pbench-user-benchmark and place information into pbench, defaults to do not use.
26-
--pbench_user <value>: user who started everything. Defaults to the current user.
27-
--pbench_copy: Copy the pbench data, not move it.
28-
--pbench_stats: What stats to gather. Defaults to all stats.
2925
--run_label: the label to associate with the pbench run. No default setting.
3026
--run_user: user that is actually running the test on the test system. Defaults to user running wrapper.
3127
--sys_type: Type of system working with, aws, azure, hostname. Defaults to hostname.
@@ -34,5 +30,3 @@ General options
3430
RHEL systems, default is none.
3531
--usage: this usage message.
3632
```
37-
38-
Note: The script does not install pbench for you. You need to do that manually.

coremark/coremark_run

Lines changed: 9 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
# set of default run parameters based on the system configuration.
2323
#
2424

25-
pbench_arg_list=""
2625
commit="none"
2726
coremark_version="v1.01"
2827
test_name="coremark"
@@ -252,15 +251,13 @@ generate_results()
252251
echo Summary not supported yet when doing cpu counts > run2_summary
253252
fi
254253

255-
if [ $to_pbench -eq 0 ]; then
256-
lines=`wc -l $results_file | cut -d' ' -f1`
257-
if [ $lines -lt 2 ]; then
258-
echo Failed > test_results_report
259-
else
260-
echo Ran > test_results_report
261-
fi
262-
${curdir}/test_tools/save_results --curdir $curdir --home_root $to_home_root --other_files "*_summary,run*log,test_results_report" --results $results_file --test_name coremark --tuned_setting=$to_tuned_setting --version $coremark_version --user $to_user
254+
lines=`wc -l $results_file | cut -d' ' -f1`
255+
if [ $lines -lt 2 ]; then
256+
echo Failed > test_results_report
257+
else
258+
echo Ran > test_results_report
263259
fi
260+
${curdir}/test_tools/save_results --curdir $curdir --home_root $to_home_root --other_files "*_summary,run*log,test_results_report" --results $results_file --test_name coremark --tuned_setting=$to_tuned_setting --version $coremark_version --user $to_user
264261
popd > /dev/null
265262
}
266263

@@ -274,9 +271,6 @@ install_test_tools "$@"
274271
# to_home_root: home directory
275272
# to_configuration: configuration information
276273
# to_times_to_run: number of times to run the test
277-
# to_pbench: Run the test via pbench
278-
# to_pbench_copy: Copy the data to the pbench repository, not move_it.
279-
# to_puser: User running pbench
280274
# to_run_label: Label for the run
281275
# to_user: User on the test system running the test
282276
# to_sys_type: for results info, basically aws, azure or local
@@ -314,17 +308,14 @@ eval set --$opts
314308
while [[ $# -gt 0 ]]; do
315309
case "$1" in
316310
--commit)
317-
pbench_arg_list="${pbench_arg_list} $1 $2"
318311
commit=$2
319312
shift 2
320313
;;
321314
--cpu_add)
322-
pbench_arg_list="${pbench_arg_list} $1 $2"
323315
cpu_add=$2
324316
shift 2
325317
;;
326318
--powers_2)
327-
pbench_arg_list="${pbench_arg_list} $1"
328319
powers_2=1
329320
shift 1
330321
;;
@@ -385,21 +376,8 @@ fi
385376
numb_cpus=`nproc`
386377
pushd coremark > /dev/null
387378

388-
if [ $to_pbench -eq 1 ]; then
389-
source ~/.bashrc
390-
cd $curdir
391-
#
392-
# Arguments to pbecnh, change as required.
393-
#
394-
pbench_args="--cmd_executing \"$0\" $arguments --test ${test_name} --spacing 11 --pbench_stats $to_pstats"
395-
echo $TOOLS_BIN/execute_via_pbench ${pbench_args}
396-
$TOOLS_BIN/execute_via_pbench ${pbench_args}
397-
if [ $? -ne 0 ]; then
398-
exit_out "Error: $TOOLS_BIN/execute_via_pbench ${pbench_args}" 1
399-
fi
400-
else
401-
run_coremark
402-
generate_results
403-
fi
379+
run_coremark
380+
generate_results
381+
404382
exit 0
405383

0 commit comments

Comments
 (0)