Only call finalizer if privdata is different

tudor · tudor · commit 6b40487b70b1 · 2021-08-02T20:03:07.000Z
diff --git a/async.c b/async.c
@@ -820,7 +820,8 @@ static int __redisAsyncCommand(redisAsyncContext *ac, redisCallbackFn *fn, redis
             if (de != NULL) {
                 existcb = dictGetEntryVal(de);
                 cb.pending_subs = existcb->pending_subs + 1;
-                __redisRunFinalizer(ac,existcb);
+                if (existcb->privdata != cb.privdata)
+                    __redisRunFinalizer(ac,existcb);
             }
 
             ret = dictReplace(cbdict,sname,&cb);

Original file line number	Diff line number	Diff line change
`@@ -820,7 +820,8 @@ static int __redisAsyncCommand(redisAsyncContext ac, redisCallbackFn fn, redis`
`820`	`820`	`if (de != NULL) {`
`821`	`821`	`existcb = dictGetEntryVal(de);`
`822`	`822`	`cb.pending_subs = existcb->pending_subs + 1;`
`823`		`- __redisRunFinalizer(ac,existcb);`
	`823`	`+ if (existcb->privdata != cb.privdata)`
	`824`	`+ __redisRunFinalizer(ac,existcb);`
`824`	`825`	`}`
`825`	`826`
`826`	`827`	`ret = dictReplace(cbdict,sname,&cb);`