Skip to content

Conversation

@uglide
Copy link
Contributor

@uglide uglide commented Nov 5, 2025

Continuation of #4311

@uglide uglide requested a review from ggivo November 5, 2025 08:58
@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Test Results

   281 files  ±0     281 suites  ±0   11m 31s ⏱️ -21s
10 197 tests ±0  10 143 ✅ ±0  54 💤 ±0  0 ❌ ±0 
 2 712 runs  ±0   2 712 ✅ ±0   0 💤 ±0  0 ❌ ±0 

Results for commit bd46c4a. ± Comparison against base commit c18881e.

♻️ This comment has been updated with latest results.

@ggivo ggivo added the breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes. label Nov 5, 2025
@uglide
Copy link
Contributor Author

uglide commented Nov 5, 2025

@ggivo I don't think it's a breaking change, since the files are internal and not used extrernaly.

@ggivo
Copy link
Collaborator

ggivo commented Nov 6, 2025

@uglide
What do you mean by not used externaly?
They are marked @deprecated but are public and not documented as internal in comments or annotated with @internal.

@uglide
Copy link
Contributor Author

uglide commented Nov 6, 2025

@ggivo see https://github.com/redis/jedis/pull/4311/files#diff-a1c95bbe6e3dc70afb41f29448973d7f61021891667a064b67d5bbc2603748b3L32-L35
This PR removes leftovers that were overseen during the JedisSharding removal. Hashing was used only for JedisSharding and is unlikely to be used without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breakingchange Pull request that has breaking changes. Must include the breaking behavior in release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants