fix(pipeline): clear placeholder pipeline error after execution (#61)

zeeshan-zomato · rueian · commit 65ace760a129 · 2025-07-28T20:16:48.000-07:00
Fixes issue where commands would retain "pipeline has not been executed"
error even after successful execution by properly setting the error state.

Signed-off-by: Zeeshan Hussain &lt;zeeshan.hussain@zomato.com&gt;
Signed-off-by: Rueian &lt;rueiancsie@gmail.com&gt;
diff --git a/rueidiscompat/pipeline.go b/rueidiscompat/pipeline.go
@@ -3210,6 +3210,7 @@ func (c *Pipeline) Exec(ctx context.Context) ([]Cmder, error) {
 		if r.NonRedisError() != nil {
 			err = r.NonRedisError()
 		}
+		rets[i].SetErr(nil)
 		rets[i].from(r)
 	}
 
diff --git a/rueidiscompat/tx.go b/rueidiscompat/tx.go
@@ -46,6 +46,7 @@ func (c *TxPipeline) Exec(ctx context.Context) ([]Cmder, error) {
 		err = TxFailedErr
 	}
 	for i, r := range results {
+		rets[i].SetErr(nil)
 		rets[i].from(*(*rueidis.RedisResult)(unsafe.Pointer(&proxyresult{
 			err: resp[i+1].NonRedisError(),
 			val: r,

Original file line number	Diff line number	Diff line change
`@@ -3210,6 +3210,7 @@ func (c *Pipeline) Exec(ctx context.Context) ([]Cmder, error) {`
`3210`	`3210`	`if r.NonRedisError() != nil {`
`3211`	`3211`	`err = r.NonRedisError()`
`3212`	`3212`	`}`
	`3213`	`+ rets[i].SetErr(nil)`
`3213`	`3214`	`rets[i].from(r)`
`3214`	`3215`	`}`
`3215`	`3216`
Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@ func (c *TxPipeline) Exec(ctx context.Context) ([]Cmder, error) {`
`46`	`46`	`err = TxFailedErr`
`47`	`47`	`}`
`48`	`48`	`for i, r := range results {`
	`49`	`+ rets[i].SetErr(nil)`
`49`	`50`	`rets[i].from((rueidis.RedisResult)(unsafe.Pointer(&proxyresult{`
`50`	`51`	`err: resp[i+1].NonRedisError(),`
`51`	`52`	`val: r,`