fix: removes object property from list (#733)

Author: cassiozen

src/common/utils/parse-contact-properties-to-api-options.ts

@@ -17,7 +17,6 @@ export function parseContactPropertyFromApi(
   return {
     id: contactProperty.id,
     key: contactProperty.key,
-    object: contactProperty.object,
     createdAt: contactProperty.created_at,
     type: contactProperty.type,
     fallbackValue: contactProperty.fallback_value,

src/contact-properties/contact-properties.spec.ts

@@ -97,15 +97,13 @@ describe('ContactProperties', () => {
             key: 'country',
             type: 'string',
             fallback_value: 'unknown',
-            object: 'contact_property',
             created_at: '2021-01-01T00:00:00.000Z',
           },
           {
             id: 'ac7503ac-e027-4aea-94b3-b0acd46f65f9',
             key: 'edition',
             type: 'number',
             fallback_value: 1,
-            object: 'contact_property',
             created_at: '2021-01-01T00:00:00.000Z',
           },
         ],
@@ -127,15 +125,13 @@ describe('ContactProperties', () => {
         "fallbackValue": "unknown",
         "id": "b6d24b8e-af0b-4c3c-be0c-359bbd97381e",
         "key": "country",
-        "object": "contact_property",
         "type": "string",
       },
       {
         "createdAt": "2021-01-01T00:00:00.000Z",
         "fallbackValue": 1,
         "id": "ac7503ac-e027-4aea-94b3-b0acd46f65f9",
         "key": "edition",
-        "object": "contact_property",
         "type": "number",
       },
     ],

src/contact-properties/contact-properties.ts

@@ -87,7 +87,10 @@ export class ContactProperties {
 
     if (response.data) {
       return {
-        data: parseContactPropertyFromApi(response.data),
+        data: {
+          object: 'contact_property',
+          ...parseContactPropertyFromApi(response.data),
+        },
         headers: response.headers,
         error: null,
       };

src/contact-properties/interfaces/contact-property.ts

@@ -11,7 +11,6 @@ type NumberBaseApiContactProperty = {
 
 export type ApiContactProperty = {
   id: string;
-  object: 'contact_property';
   created_at: string;
   key: string;
 } & (StringBaseApiContactProperty | NumberBaseApiContactProperty);
@@ -29,7 +28,6 @@ type NumberBaseContactProperty = {
 
 export type ContactProperty = {
   id: string;
-  object: 'contact_property';
   createdAt: string;
   key: string;
 } & (StringBaseContactProperty | NumberBaseContactProperty);

src/contact-properties/interfaces/create-contact-property-options.interface.ts

@@ -25,8 +25,10 @@ export interface CreateContactPropertyApiOptions {
 
 export type CreateContactPropertyResponseSuccess = Pick<
   ContactProperty,
-  'id' | 'object'
->;
+  'id'
+> & {
+  object: 'contact_property';
+};
 
 export type CreateContactPropertyResponse =
   Response<CreateContactPropertyResponseSuccess>;

src/contact-properties/interfaces/delete-contact-property-options.interface.ts

@@ -3,8 +3,9 @@ import type { ContactProperty } from './contact-property';
 
 export type RemoveContactPropertyResponseSuccess = Pick<
   ContactProperty,
-  'id' | 'object'
+  'id'
 > & {
+  object: 'contact_property';
   deleted: boolean;
 };
 

src/contact-properties/interfaces/get-contact-property.interface.ts

@@ -1,6 +1,12 @@
 import type { Response } from '../../interfaces';
 import type { ApiContactProperty, ContactProperty } from './contact-property';
 
-export type GetContactPropertyResponseSuccess = ApiContactProperty;
+export type GetContactPropertyResponseSuccess = ApiContactProperty & {
+  object: 'contact_property';
+};
 
-export type GetContactPropertyResponse = Response<ContactProperty>;
+export type GetContactPropertyResponse = Response<
+  ContactProperty & {
+    object: 'contact_property';
+  }
+>;

src/contact-properties/interfaces/update-contact-property-options.interface.ts

@@ -14,8 +14,10 @@ export interface UpdateContactPropertyApiOptions {
 
 export type UpdateContactPropertyResponseSuccess = Pick<
   ContactProperty,
-  'id' | 'object'
->;
+  'id'
+> & {
+  object: 'contact_property';
+};
 
 export type UpdateContactPropertyResponse =
   Response<UpdateContactPropertyResponseSuccess>;