Merge branch 'master' of https://github.com/rollup/rollup into sync-79d5563a

docschina-bot · docschina-bot · commit 1886d2790b3b · 2025-09-07T22:13:19.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,21 @@
 # rollup changelog
 
+## 4.50.1
+
+_2025-09-07_
+
+### Bug Fixes
+
+- Resolve a situation where a destructuring default value was removed (#6090)
+
+### Pull Requests
+
+- [#6088](https://github.com/rollup/rollup/pull/6088): feat(www): shorter repl shareables (@cyyynthia, @lukastaegert)
+- [#6090](https://github.com/rollup/rollup/pull/6090): Call includeNode for self or children nodes in includeDestructuredIfNecessary (@TrickyPi)
+- [#6091](https://github.com/rollup/rollup/pull/6091): fix(deps): update rust crate swc_compiler_base to v33 (@renovate[bot])
+- [#6092](https://github.com/rollup/rollup/pull/6092): chore(deps): lock file maintenance minor/patch updates (@renovate[bot])
+- [#6094](https://github.com/rollup/rollup/pull/6094): perf: replace startsWith with strict equality (@btea)
+
 ## 4.50.0
 
 _2025-08-31_
diff --git a/browser/package.json b/browser/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@rollup/browser",
-  "version": "4.50.0",
+  "version": "4.50.1",
   "description": "Next-generation ES module bundler browser build",
   "main": "dist/rollup.browser.js",
   "module": "dist/es/rollup.browser.js",
diff --git a/docs/.vitepress/verify-anchors.ts b/docs/.vitepress/verify-anchors.ts
@@ -41,7 +41,7 @@ function verifyAnchorsOnPage(page: string, slugs: Set<string>) {
 	let match: (RegExpExecArray & { groups?: { href?: string } }) | null;
 	while ((match = markdownLinkRegExp.exec(text)) !== null) {
 		const [href] = match;
-		if (href.startsWith('#')) {
+		if (href[0] === '#') {
 			const anchor = href.slice(1);
 			if (!slugs.has(anchor)) {
 				console.log(slugs);
diff --git a/docs/repl/helpers/query.ts b/docs/repl/helpers/query.ts
@@ -16,7 +16,7 @@ export async function useUpdateStoresFromQuery() {
 	try {
 		if (query.shareable) {
 			const rawJson = atob(query.shareable.replace(/_/g, '/').replace(/-/g, '+'));
-			const json = rawJson.startsWith('%') ? decodeURIComponent(rawJson) : rawJson;
+			const json = rawJson[0] === '%' ? decodeURIComponent(rawJson) : rawJson;
 			const {
 				modules: queryModules,
 				options: queryOptions,
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "rollup",
-  "version": "4.50.0",
+  "version": "4.50.1",
   "description": "Next-generation ES module bundler",
   "main": "dist/rollup.js",
   "module": "dist/es/rollup.js",
diff --git a/scripts/test-options.js b/scripts/test-options.js
@@ -73,7 +73,7 @@ for (const line of splitHelpText) {
 	}
 }
 
-const helpOptionLines = splitHelpText.filter(line => line.startsWith('-'));
+const helpOptionLines = splitHelpText.filter(line => line[0] === '-');
 
 const cliFlagsText = commandReferenceText
 	.split('\n## ')
@@ -85,7 +85,7 @@ const cliMarkdownSection = cliFlagsText.match(/```\n([\S\s]*?)\n```/);
 if (!cliMarkdownSection) {
 	throw new Error('Could not find markdown section in "Command line flags" section.');
 }
-const optionListLines = cliMarkdownSection[1].split('\n').filter(line => line.startsWith('-'));
+const optionListLines = cliMarkdownSection[1].split('\n').filter(line => line[0] === '-');
 
 for (const [index, line] of helpOptionLines.entries()) {
 	const optionListLine = optionListLines[index];
diff --git a/src/Chunk.ts b/src/Chunk.ts
@@ -966,7 +966,7 @@ export default class Chunk {
 							variable.isNamespace &&
 							namespaceInteropHelpersByInteropType[interop(module.id)] &&
 							(this.imports.has(variable) ||
-								!this.exportNamesByVariable.get(variable)?.every(name => name.startsWith('*')))
+								!this.exportNamesByVariable.get(variable)?.every(name => name[0] === '*'))
 						) {
 							// We only need to deconflict it if the namespace is actually
 							// created as a variable, i.e. because it is used internally or
@@ -1143,7 +1143,7 @@ export default class Chunk {
 				return idWithoutExtension.slice(preserveModulesRoot.length).replace(/^[/\\]/, '');
 			} else {
 				// handle edge case in Windows
-				if (this.inputBase === '/' && !idWithoutExtension.startsWith('/')) {
+				if (this.inputBase === '/' && idWithoutExtension[0] !== '/') {
 					return relative(this.inputBase, idWithoutExtension.replace(/^[a-zA-Z]:[/\\]/, '/'));
 				}
 				return relative(this.inputBase, idWithoutExtension);
diff --git a/src/ast/nodes/ArrayPattern.ts b/src/ast/nodes/ArrayPattern.ts
@@ -86,24 +86,19 @@ export default class ArrayPattern extends NodeBase implements DeclarationPattern
 	): boolean {
 		let included = false;
 		const includedPatternPath = getIncludedPatternPath(destructuredInitPath);
-		for (const element of this.elements) {
+		for (const element of [...this.elements].reverse()) {
 			if (element) {
-				element.included ||= included;
+				if (included && !element.included) {
+					element.includeNode(context);
+				}
 				included =
 					element.includeDestructuredIfNecessary(context, includedPatternPath, init) || included;
 			}
 		}
-		if (included) {
-			// This is necessary so that if any pattern element is included, all are
-			// included for proper deconflicting
-			for (const element of this.elements) {
-				if (element && !element.included) {
-					element.included = true;
-					element.includeDestructuredIfNecessary(context, includedPatternPath, init);
-				}
-			}
+		if (!this.included && included) {
+			this.includeNode(context);
 		}
-		return (this.included ||= included);
+		return this.included;
 	}
 
 	markDeclarationReached(): void {
diff --git a/src/ast/nodes/AssignmentPattern.ts b/src/ast/nodes/AssignmentPattern.ts
@@ -71,13 +71,16 @@ export default class AssignmentPattern extends NodeBase implements DeclarationPa
 		if ((included ||= this.right.shouldBeIncluded(context))) {
 			this.right.include(context, false);
 			if (!this.left.included) {
-				this.left.included = true;
+				this.left.includeNode(context);
 				// Unfortunately, we need to include the left side again now, so that
 				// any declared variables are properly included.
 				this.left.includeDestructuredIfNecessary(context, destructuredInitPath, init);
 			}
 		}
-		return (this.included = included);
+		if (!this.included && included) {
+			this.includeNode(context);
+		}
+		return this.included;
 	}
 
 	includeNode(context: InclusionContext) {
diff --git a/src/ast/nodes/Identifier.ts b/src/ast/nodes/Identifier.ts
@@ -115,8 +115,9 @@ export default class Identifier extends IdentifierBase implements DeclarationPat
 		}
 		const { propertyReadSideEffects } = this.scope.context.options
 			.treeshake as NormalizedTreeshakingOptions;
+		let included = this.included;
 		if (
-			(this.included ||=
+			(included ||=
 				destructuredInitPath.length > 0 &&
 				!context.brokenFlow &&
 				propertyReadSideEffects &&
@@ -131,9 +132,11 @@ export default class Identifier extends IdentifierBase implements DeclarationPat
 				this.scope.context.includeVariableInModule(this.variable, EMPTY_PATH, context);
 			}
 			init.includePath(destructuredInitPath, context);
-			return true;
 		}
-		return false;
+		if (!this.included && included) {
+			this.includeNode(context);
+		}
+		return this.included;
 	}
 
 	markDeclarationReached(): void {
diff --git a/src/ast/nodes/MemberExpression.ts b/src/ast/nodes/MemberExpression.ts
@@ -7,7 +7,7 @@ import { logIllegalImportReassignment, logMissingExport } from '../../utils/logs
 import type { NodeRenderOptions, RenderOptions } from '../../utils/renderHelpers';
 import type { DeoptimizableEntity } from '../DeoptimizableEntity';
 import type { HasEffectsContext, InclusionContext } from '../ExecutionContext';
-import { createHasEffectsContext, createInclusionContext } from '../ExecutionContext';
+import { createInclusionContext } from '../ExecutionContext';
 import type {
 	NodeInteraction,
 	NodeInteractionAccessed,
@@ -440,25 +440,14 @@ export default class MemberExpression
 		}
 	}
 
-	includeDestructuredIfNecessary(
-		context: InclusionContext,
-		destructuredInitPath: ObjectPath,
-		init: ExpressionEntity
-	): boolean {
-		if (
-			(this.included ||=
-				destructuredInitPath.length > 0 &&
-				!context.brokenFlow &&
-				init.hasEffectsOnInteractionAtPath(
-					destructuredInitPath,
-					NODE_INTERACTION_UNKNOWN_ACCESS,
-					createHasEffectsContext()
-				))
-		) {
-			init.include(context, false);
-			return true;
-		}
-		return false;
+	includeDestructuredIfNecessary(): boolean {
+		/* istanbul ignore next */
+		this.scope.context.error(
+			{
+				message: 'includeDestructuredIfNecessary is currently not supported for MemberExpressions'
+			},
+			this.start
+		);
 	}
 
 	initialise(): void {
diff --git a/src/ast/nodes/ObjectPattern.ts b/src/ast/nodes/ObjectPattern.ts
@@ -87,25 +87,23 @@ export default class ObjectPattern extends NodeBase implements DeclarationPatter
 		destructuredInitPath: ObjectPath,
 		init: ExpressionEntity
 	): boolean {
-		if (!this.properties.length) return false;
+		if (!this.properties.length) return this.included;
 
 		const lastProperty = this.properties.at(-1)!;
-		const lastPropertyIncluded = lastProperty.includeDestructuredIfNecessary(
-			context,
-			destructuredInitPath,
-			init
-		);
+		let included = lastProperty.includeDestructuredIfNecessary(context, destructuredInitPath, init);
 		const lastPropertyIsRestElement = lastProperty.type === NodeType.RestElement;
 
-		let included = lastPropertyIsRestElement ? lastPropertyIncluded : false;
 		for (const property of this.properties.slice(0, -1)) {
-			if (lastPropertyIsRestElement && lastPropertyIncluded) {
+			if (lastPropertyIsRestElement && included && !property.included) {
 				property.includeNode(context);
 			}
 			included =
 				property.includeDestructuredIfNecessary(context, destructuredInitPath, init) || included;
 		}
-		return (this.included ||= included);
+		if (!this.included && included) {
+			this.includeNode(context);
+		}
+		return this.included;
 	}
 
 	markDeclarationReached(): void {
diff --git a/src/ast/nodes/Property.ts b/src/ast/nodes/Property.ts
@@ -84,13 +84,16 @@ export default class Property extends MethodBase implements DeclarationPatternNo
 		if ((included ||= this.key.hasEffects(createHasEffectsContext()))) {
 			this.key.include(context, false);
 			if (!this.value.included) {
-				this.value.included = true;
+				this.value.includeNode(context);
 				// Unfortunately, we need to include the value again now, so that any
 				// declared variables are properly included.
 				(this.value as PatternNode).includeDestructuredIfNecessary(context, path, init);
 			}
 		}
-		return (this.included = included);
+		if (!this.included && included) {
+			this.includeNode(context);
+		}
+		return this.included;
 	}
 
 	include(context: InclusionContext, includeChildrenRecursively: IncludeChildren) {
diff --git a/src/ast/nodes/RestElement.ts b/src/ast/nodes/RestElement.ts
@@ -73,12 +73,15 @@ export default class RestElement extends NodeBase implements DeclarationPatternN
 		destructuredInitPath: ObjectPath,
 		init: ExpressionEntity
 	): boolean {
-		return (this.included =
-			this.argument.includeDestructuredIfNecessary(
-				context,
-				getIncludedPatternPath(destructuredInitPath),
-				init
-			) || this.included);
+		const included = this.argument.includeDestructuredIfNecessary(
+			context,
+			getIncludedPatternPath(destructuredInitPath),
+			init
+		);
+		if (!this.included && included) {
+			this.includeNode(context);
+		}
+		return this.included;
 	}
 
 	include(context: InclusionContext, includeChildrenRecursively: IncludeChildren) {
diff --git a/src/utils/getLogFilter.ts b/src/utils/getLogFilter.ts
@@ -5,7 +5,7 @@ export const getLogFilter: GetLogFilter = filters => {
 	if (filters.length === 0) return () => true;
 	const normalizedFilters = filters.map(filter =>
 		filter.split('&').map(subFilter => {
-			const inverted = subFilter.startsWith('!');
+			const inverted = subFilter[0] === '!';
 			if (inverted) subFilter = subFilter.slice(1);
 			const [key, ...value] = subFilter.split(':');
 			return { inverted, key: key.split('.'), parts: value.join(':').split('*') };
diff --git a/src/utils/options/normalizeInputOptions.ts b/src/utils/options/normalizeInputOptions.ts
@@ -97,7 +97,7 @@ const getIdMatcher = <T extends any[]>(
 		return () => true;
 	}
 	if (typeof option === 'function') {
-		return (id, ...parameters) => (!id.startsWith('\0') && option(id, ...parameters)) || false;
+		return (id, ...parameters) => (id[0] !== '\0' && option(id, ...parameters)) || false;
 	}
 	if (option) {
 		const ids = new Set<string>();
@@ -241,7 +241,7 @@ const getHasModuleSideEffects = (
 	}
 	if (typeof moduleSideEffectsOption === 'function') {
 		return (id, external) =>
-			id.startsWith('\0') ? true : moduleSideEffectsOption(id, external) !== false;
+			id[0] === '\0' ? true : moduleSideEffectsOption(id, external) !== false;
 	}
 	if (Array.isArray(moduleSideEffectsOption)) {
 		const ids = new Set(moduleSideEffectsOption);
diff --git a/test/function/samples/external-ignore-reserved-null-marker/_config.js b/test/function/samples/external-ignore-reserved-null-marker/_config.js
@@ -2,7 +2,7 @@ module.exports = defineTest({
 	description: 'external function ignores \\0 started ids',
 	options: {
 		external(id) {
-			if (id.startsWith('\0')) {
+			if (id[0] === '\0') {
 				throw new Error('\\0 started ids should not be tested as external');
 			}
 			return true;
diff --git a/test/function/samples/keep-the-non-first-assignment-in-destructuring-unknown-array-variables/_config.js b/test/function/samples/keep-the-non-first-assignment-in-destructuring-unknown-array-variables/_config.js
@@ -0,0 +1,6 @@
+module.exports = defineTest({
+	description: 'Keep the non-first assignment in destructuring unknown array variables',
+	context: {
+		unknownVariable: []
+	}
+});
diff --git a/test/function/samples/keep-the-non-first-assignment-in-destructuring-unknown-array-variables/main.js b/test/function/samples/keep-the-non-first-assignment-in-destructuring-unknown-array-variables/main.js
@@ -0,0 +1,2 @@
+const [a, last2 = { foo: true }] = unknownVariable;
+assert.ok(last2.foo);
diff --git a/test/testHelpers.js b/test/testHelpers.js
@@ -497,7 +497,7 @@ const replaceStringifyValues = (key, value) => {
 		}
 	}
 
-	return key.startsWith('_')
+	return key[0] === '_'
 		? undefined
 		: typeof value == 'bigint'
 			? `~BigInt${value.toString()}`

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@rollup/browser",`
`3`		`- "version": "4.50.0",`
	`3`	`+ "version": "4.50.1",`
`4`	`4`	`"description": "Next-generation ES module bundler browser build",`
`5`	`5`	`"main": "dist/rollup.browser.js",`
`6`	`6`	`"module": "dist/es/rollup.browser.js",`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "rollup",`
`3`		`- "version": "4.50.0",`
	`3`	`+ "version": "4.50.1",`
`4`	`4`	`"description": "Next-generation ES module bundler",`
`5`	`5`	`"main": "dist/rollup.js",`
`6`	`6`	`"module": "dist/es/rollup.js",`
Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ for (const line of splitHelpText) {`
`73`	`73`	`}`
`74`	`74`	`}`
`75`	`75`
`76`		`-const helpOptionLines = splitHelpText.filter(line => line.startsWith('-'));`
	`76`	`+const helpOptionLines = splitHelpText.filter(line => line[0] === '-');`
`77`	`77`
`78`	`78`	`const cliFlagsText = commandReferenceText`
`79`	`79`	`.split('\n## ')`
@@ -85,7 +85,7 @@ const cliMarkdownSection = cliFlagsText.match(/```\n([\S\s]*?)\n```/);
`85`	`85`	`if (!cliMarkdownSection) {`
`86`	`86`	`throw new Error('Could not find markdown section in "Command line flags" section.');`
`87`	`87`	`}`
`88`		`-const optionListLines = cliMarkdownSection[1].split('\n').filter(line => line.startsWith('-'));`
	`88`	`+const optionListLines = cliMarkdownSection[1].split('\n').filter(line => line[0] === '-');`
`89`	`89`
`90`	`90`	`for (const [index, line] of helpOptionLines.entries()) {`
`91`	`91`	`const optionListLine = optionListLines[index];`
Original file line number	Diff line number	Diff line change
`@@ -71,13 +71,16 @@ export default class AssignmentPattern extends NodeBase implements DeclarationPa`
`71`	`71`	`if ((included \|\|= this.right.shouldBeIncluded(context))) {`
`72`	`72`	`this.right.include(context, false);`
`73`	`73`	`if (!this.left.included) {`
`74`		`- this.left.included = true;`
	`74`	`+ this.left.includeNode(context);`
`75`	`75`	`// Unfortunately, we need to include the left side again now, so that`
`76`	`76`	`// any declared variables are properly included.`
`77`	`77`	`this.left.includeDestructuredIfNecessary(context, destructuredInitPath, init);`
`78`	`78`	`}`
`79`	`79`	`}`
`80`		`- return (this.included = included);`
	`80`	`+ if (!this.included && included) {`
	`81`	`+ this.includeNode(context);`
	`82`	`+ }`
	`83`	`+ return this.included;`
`81`	`84`	`}`
`82`	`85`
`83`	`86`	`includeNode(context: InclusionContext) {`