Address all offenses except two files

Author: flash-gordon

.rubocop.yml

@@ -43,6 +43,7 @@ Lint/ConstantDefinitionInBlock:
 
 Lint/EmptyBlock:
   Exclude:
+    - "lib/rom/sql/migration/template.rb"
     - "spec/**/*.rb"
     - "tmp/**/*.rb"
 
@@ -179,6 +180,9 @@ Style/OpenStructUse:
 Style/ParallelAssignment:
   Enabled: false
 
+Style/SafeNavigation:
+  MaxChainLength: 1
+
 Style/StabbyLambdaParentheses:
   Enabled: false
 

Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)

lib/rom/plugins/relation/sql/auto_restrictions.rb

@@ -39,6 +39,8 @@ module AutoRestrictions
           end
 
           # @api private
+          #
+          # rubocop:disable Metrics/AbcSize
           def self.restriction_methods(schema)
             mod = Module.new
 
@@ -72,6 +74,7 @@ def self.restriction_methods(schema)
             [methods, mod]
           end
         end
+        # rubocop:enable Metrics/AbcSize
       end
     end
   end

lib/rom/plugins/relation/sql/postgres/explain.rb

@@ -26,7 +26,7 @@ module Explain
             #
             # @api public
             def explain(format: :text, **options)
-              bool_options = options.map { |opt, value| "#{opt.to_s.upcase} #{!!value}" }
+              bool_options = options.map { "#{_1.to_s.upcase} #{!!_2}" } # rubocop:disable Style/DoubleNegation
               format_option = "FORMAT #{format.to_s.upcase}"
               explain_value = [format_option, *bool_options].join(', ')
 

lib/rom/plugins/relation/sql/postgres/full_text_search.rb

@@ -13,23 +13,40 @@ module FullTextSearch
             # By default, searching for the inclusion of any of the terms in any of the cols.
             #
             # @example
-            #   posts.full_text_search([:title, :content], 'apples', language: 'english') # => Relation which match the 'apples' phrase
+            #   posts.full_text_search([:title, :content], 'apples', language: 'english')
+            #   # => Relation which match the 'apples' phrase
             #
-            # @option :headline [String] Append a expression to the selected columns aliased to headline that contains an extract of the matched text.
+            # @option :headline [String]
+            #   Append a expression to the selected columns aliased
+            #   to headline that contains an extract of the matched text.
             #
-            # @option :language [String] The language to use for the search (default: 'simple')
+            # @option :language [String]
+            #   The language to use for the search (default: 'simple')
             #
-            # @option :plain [Boolean] Whether a plain search should be used (default: false).  In this case, terms should be a single string, and it will do a search where cols contains all of the words in terms.  This ignores search operators in terms.
+            # @option :plain [Boolean]
+            #   Whether a plain search should be used (default: false).
+            #   In this case, terms should be a single string, and it will do a search
+            #   where cols contains all of the words in terms.
+            #   This ignores search operators in terms.
             #
-            # @option :phrase [Boolean] Similar to :plain, but also adding an ILIKE filter to ensure that returned rows also include the exact phrase used.
+            # @option :phrase [Boolean]
+            #   Similar to :plain, but also adding an ILIKE filter to ensure
+            #   that returned rows also include the exact phrase used.
             #
-            # @option :rank [Boolean] Set to true to order by the rank, so that closer matches are returned first.
+            # @option :rank [Boolean]
+            #   Set to true to order by the rank, so that closer matches are returned first.
             #
-            # @option :to_tsquery [Symbol] Can be set to :plain or :phrase to specify the function to use to convert the terms to a ts_query.
+            # @option :to_tsquery [Symbol]
+            #   Can be set to :plain or :phrase to specify the function to use
+            #   to convert the terms to a ts_query.
             #
-            # @option :tsquery [Boolean] Specifies the terms argument is already a valid SQL expression returning a tsquery, and can be used directly in the query.
+            # @option :tsquery [Boolean]
+            #   Specifies the terms argument is already a valid SQL expression returning a tsquery,
+            #   and can be used directly in the query.
             #
-            # @option :tsvector [Boolean] Specifies the cols argument is already a valid SQL expression returning a tsvector, and can be used directly in the query.
+            # @option :tsvector [Boolean]
+            #   Specifies the cols argument is already a valid SQL expression returning a tsvector,
+            #   and can be used directly in the query.
             #
             # @return [Relation]
             #

lib/rom/sql/associations/many_to_many.rb

@@ -12,6 +12,8 @@ class ManyToMany < ROM::Associations::ManyToMany
         include Associations::SelfRef
 
         # @api public
+        #
+        # rubocop:disable Metrics/AbcSize
         def call(target: self.target)
           left = join_assoc.(target: target)
 
@@ -34,6 +36,7 @@ def call(target: self.target)
             schema.(relation)
           end
         end
+        # rubocop:enable Metrics/AbcSize
 
         # @api public
         def join(type, source = self.source, target = self.target)

lib/rom/sql/associations/many_to_one.rb

@@ -12,6 +12,8 @@ class ManyToOne < ROM::Associations::ManyToOne
         include Associations::SelfRef
 
         # @api public
+        #
+        # rubocop:disable Metrics/AbcSize
         def call(target: self.target, preload: false)
           if preload
             schema = target.schema.qualified
@@ -41,6 +43,7 @@ def call(target: self.target, preload: false)
             schema.(relation)
           end
         end
+        # rubocop:enable Metrics/AbcSize
 
         # @api public
         def join(type, source = self.source, target = self.target)

lib/rom/sql/attribute.rb

@@ -15,6 +15,8 @@ module SQL
     # Extended schema attributes tailored for SQL databases
     #
     # @api public
+    #
+    # rubocop:disable Metrics/ClassLength
     class Attribute < ROM::Attribute
       include AttributeWrapping
       include AttributeAliasing
@@ -59,7 +61,9 @@ def qualified(table_alias = nil)
         return meta(qualified: false) unless qualifiable?
 
         case sql_expr
-        when Sequel::SQL::AliasedExpression, Sequel::SQL::Identifier, Sequel::SQL::QualifiedIdentifier
+        when ::Sequel::SQL::AliasedExpression,
+             ::Sequel::SQL::Identifier,
+             ::Sequel::SQL::QualifiedIdentifier
           attr = meta(qualified: table_alias || true)
           attr.meta(sql_expr: attr.to_sql_name)
         else
@@ -334,7 +338,7 @@ def meta_options_ast
       #
       # @api private
       def unwrap
-        cleaned_meta = meta.reject { |k, _| META_KEYS.include?(k) }
+        cleaned_meta = meta.except(*META_KEYS)
         type = optional? ? right : self.type
 
         self.class.new(type.with(meta: cleaned_meta), **options)
@@ -383,6 +387,15 @@ def sql_expr
         @sql_expr ||= meta[:sql_expr] || to_sql_name
       end
 
+      # @api private
+      def respond_to_missing?(meth, _include_private = false)
+        if OPERATORS.include?(meth) || extensions.key?(meth) || sql_expr.respond_to?(meth)
+          true
+        else
+          super
+        end
+      end
+
       # Delegate to sql expression if it responds to a given method
       #
       # @api private
@@ -436,5 +449,6 @@ def extensions
 
       memoize :joined, :to_sql_name, :table_name, :canonical
     end
+    # rubocop:enable Metrics/ClassLength
   end
 end

lib/rom/sql/dsl.rb

@@ -59,7 +59,9 @@ def `(value)
       #
       # @example
       #   users.where { exists(users.where(name: 'John')) }
-      #   users.select_append { |r| exists(r[:posts].where(r[:posts][:user_id] => id)).as(:has_posts) }
+      #   users.select_append { |r|
+      #     exists(r[:posts].where(r[:posts][:user_id] => id)).as(:has_posts)
+      #   }
       #
       # @api public
       def exists(relation)

lib/rom/sql/extensions/postgres/types/json.rb

@@ -77,11 +77,15 @@ def inspect
           end
         else
           JSON = Type('json') do
-            (SQL::Types::Array | SQL::Types::Hash).constructor(Sequel.method(:pg_json)).meta(read: JSONRead)
+            (SQL::Types::Array | SQL::Types::Hash).constructor(
+              ::Sequel.method(:pg_json)
+            ).meta(read: JSONRead)
           end
 
           JSONB = Type('jsonb') do
-            (SQL::Types::Array | SQL::Types::Hash).constructor(Sequel.method(:pg_jsonb)).meta(read: JSONRead)
+            (SQL::Types::Array | SQL::Types::Hash).constructor(
+              ::Sequel.method(:pg_jsonb)
+            ).meta(read: JSONRead)
           end
         end
 
@@ -265,7 +269,9 @@ def contained_by(_type, expr, value)
           end
 
           def has_key(_type, expr, key)
-            Attribute[SQL::Types::Bool].meta(sql_expr: wrap(expr).has_key?(key))
+            Attribute[SQL::Types::Bool].meta(
+              sql_expr: wrap(expr).has_key?(key) # rubocop:disable Style/PreferredHashMethods
+            )
           end
 
           def has_any_key(_type, expr, *keys)