Fix Support for ssh-certificates #477
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Senjuu
force-pushed
the
fix-sign-certificate
branch
9 times, most recently
from
f0534ef to
4f5db51
Compare
kucejan
reviewed
Mar 10, 2024
| res['public_key'] = formats.parse_pubkey(public_key) | ||
| _certificate = certificate.parse(data) | ||
| if _certificate['isCertificate']: | ||
| certificate.format(_certificate) |
There was a problem hiding this comment.
There is no format() defined in libagent.ssh.certificate module.
It produces the following error:
Traceback (most recent call last):
File "/XYZ/lib/python3.10/site-packages/libagent/server.py", line 103, in handle_connection
reply = handler.handle(msg=msg)
File "/XYZ/lib/python3.10/site-packages/libagent/ssh/protocol.py", line 106, in handle
reply = method(buf=buf)
File "/XYZ/lib/python3.10/site-packages/libagent/ssh/protocol.py", line 147, in sign_message
signature = self.conn.sign(blob=blob, identity=key['identity'])
File "/XYZ/lib/python3.10/site-packages/libagent/ssh/__init__.py", line 279, in sign
return conn.sign_ssh_challenge(blob=blob, identity=identity)
File "/XYZ/lib/python3.10/site-packages/libagent/ssh/client.py", line 35, in sign_ssh_challenge
msg = parse_ssh_blob(blob)
File "/XYZ/lib/python3.10/site-packages/libagent/ssh/client.py", line 80, in parse_ssh_blob
certificate.format(_certificate)
AttributeError: module 'libagent.ssh.certificate' has no attribute 'format'
3a2f141 to
f710988
Compare
Senjuu
force-pushed
the
fix-sign-certificate
branch
from
f710988 to
fc7684d
Compare
Author
|
As I removed some private modifications that I do not recommend for public use I seem to have removed one to many function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallo romanz,
I recently found an error from my first merge-request (#373) as I did the requested rebase and squash. So I am now posting the missing changes.