rework signify arguments for compatiblity with signify and minisign #503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both signify and minisign have a concept of untrusted comment, which if signing by default seems to point to the pubkey. If available, the option for untrusted comment only ever seems to be -c. Only minisign seems to have a concept of a trusted comment and the option for a trusted comment is -t This commit makes the trusted comment optional (defaults to off, previously defaulted to time.asctime()). This removes the unneeded signing and prompt round for those who do not need or use the trusted comment section. This commit also brings the `trezor-signify` command line closer to the minisign and signify tools, which unfortunately seems to be a breaking change, but the previous state seemed to be more messy.
Signify tool (but not minisign) supports embedding message after the signature (-e). Add the option to embed the message as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both signify and minisign have a concept of untrusted comment, which if signing by default seems to point to the pubkey. If available, the option for untrusted comment only ever seems to be -c.
Only minisign seems to have a concept of a trusted comment and the option for a trusted comment is -t
This commit makes the trusted comment optional
(defaults to off, previously defaulted to time.asctime()). This removes the unneeded signing and prompt round for those who do not need or use the trusted comment section.
This commit also brings the
trezor-signifycommand line closer to the minisign and signify tools, which unfortunately seems to be a breaking change, but the previous state seemed to be more messy.This fixes #502