Possible implementation for social share #70
Draft
+83
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abder
requested review from
NicestRudeGuy,
VijayaRaghavanM,
bilouStrike,
imranhsayed and
m-muhsin
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/rtcamp/wp-decoupled/qy88ysk7f |
2 tasks
imranhsayed
requested changes
Feb 17, 2021
Contributor
imranhsayed
left a comment
imranhsayed
left a comment
There was a problem hiding this comment.
Nice work @DOUARA . We need to add the SEO component first that adds the necessary og meta tags using Yoast. Then we can bring this PR in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one possible implementation for social share buttons described in #61
I used
react-sharelibrary which looks solid and supported for long term, building our own solution would be just a waste of time in my opinion as we gonna be building the same library.After we create
wp-decoupled-helperplugin ( #59 ) we will add options for user to choose which social sites to include and also which post types to display the share buttons in.