Merge pull request #340 from Earlopain/multiple-assertions-receiver

[Fix #321] Fix false positives for `Minitest/MultipleAssertions` when the assertion has a receiver

Author: koic

changelog/fix_false_positives_multiple_assertions_receiver.md

@@ -0,0 +1 @@
+* [#321](https://github.com/rubocop/rubocop-minitest/issues/321): Fix false positives for `Minitest/MultipleAssertions` when the assertion has a receiver. ([@earlopain][])

lib/rubocop/cop/mixin/minitest_exploration_helpers.rb

@@ -114,22 +114,24 @@ def assertions_count(node)
         end
       end
 
-      # rubocop:disable Metrics/CyclomaticComplexity
       def assertion_method?(node)
         return false unless node
         return assertion_method?(node.expression) if node.assignment? && node.respond_to?(:expression)
         return false unless node.type?(:send, :any_block)
 
-        method_name = node.method_name
-        assertion_method = ASSERTION_PREFIXES.any? { |prefix| method_name.start_with?(prefix.to_s) }
-
-        assertion_method || node.method?(:flunk) || MATCHER_METHODS.include?(method_name)
+        assertion_prefix_method?(node) || node.method?(:flunk) || MATCHER_METHODS.include?(node.method_name)
       end
-      # rubocop:enable Metrics/CyclomaticComplexity
 
       def lifecycle_hook_method?(node)
         node.def_type? && LIFECYCLE_HOOK_METHODS.include?(node.method_name)
       end
+
+      def assertion_prefix_method?(node)
+        return false if node.receiver
+
+        method_name = node.method_name
+        ASSERTION_PREFIXES.any? { |prefix| method_name.start_with?(prefix.to_s) }
+      end
     end
   end
 end

test/rubocop/cop/minitest/multiple_assertions_test.rb

@@ -745,6 +745,16 @@ class FooTest < ActiveSupport::TestCase
     RUBY
   end
 
+  def test_does_not_register_offense_with_receiver
+    assert_no_offenses(<<~RUBY)
+      class FooTest < Minitest::Test
+        def test_asserts_once
+          assert_equal(foo, Bar.assert_something)
+        end
+      end
+    RUBY
+  end
+
   private
 
   def configure_max_assertions(max)