Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to compare the output of two different prism versions.
It compiles prism twice and forks to allow for different versions in the same script. It then passes over minimal data to see if anything has changed.
Most bugfixes should impact little to no real code and the test suite is already very extensive. Running this can give you even more confidence by comparing against real-world-rails or similar.
There are some performance gains to be had here. Basically it is already parallelized because of
forkbut it can be even better. For simplicity (and because I don't usually write such code) I leave that as an exercise for the future. The message on change can also be improved, but right now I'm not certain that's worth the effort. Just check it manually via the already existing tools.Would have shown that #3669 isn't quite right.