Follow the repo's factory and spec-layout conventions

Self-review against existing patterns rather than anything new. Three deviations, all
in specs added earlier on this branch.

Four places built records with `Model.create!` where the repo uses factories.
`create(:promotion_rate, checkin_id: ...)` is already the established call in
`checkins_controller_spec.rb`, so there was a working pattern to follow and these
did not. Switched to factories throughout, and added the two that were missing:

  spec/factories/harvey_bradshaw_indices.rb
  spec/factories/oracle_requests.rb

`spec/factories/topic_followings.rb` existed but was an empty block, so
`create(:topic_following)` raised on the model's `encrypted_user_id` presence
validation -- the factory was declared but unusable. It now supplies one, which is why
three call sites here collapse to a bare `create(:topic_following)`.

All four new or amended factories are valid with no arguments; I checked that
explicitly rather than relying on them happening to work with the arguments these
specs pass.

`spec/mailers/` is one file per mailer class, and `app/mailers/promotion_rate/` holds
two classes, so the combined `promotion_rate_mailers_spec.rb` is split into
`spec/mailers/promotion_rate/statistic_mailer_spec.rb` and `low_rate_mailer_spec.rb`,
mirroring the app tree the way the other spec directories do.

561 examples, 0 failures. standardrb clean.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: claude

backend/spec/controllers/api/v1/harvey_bradshaw_indices_controller_spec.rb

@@ -52,7 +52,7 @@
 
   describe "show" do
     let!(:index) do
-      HarveyBradshawIndex.create!(attributes.merge(checkin_id: checkin.id))
+      create(:harvey_bradshaw_index, attributes.merge(checkin_id: checkin.id))
     end
 
     it "returns the requested index" do

backend/spec/controllers/api/v1/oracle_requests_controller_spec.rb

@@ -32,7 +32,7 @@
   end
 
   describe "update" do
-    let!(:oracle_request) { OracleRequest.create!(age: 30, token: "the-token") }
+    let!(:oracle_request) { create(:oracle_request, age: 30, token: "the-token") }
 
     it "accepts an edit from the holder of the token" do
       request.headers["X-Oracle-Token"] = "the-token"
@@ -74,7 +74,7 @@
   end
 
   describe "show" do
-    let!(:oracle_request) { OracleRequest.create!(age: 30, token: "the-token") }
+    let!(:oracle_request) { create(:oracle_request, age: 30, token: "the-token") }
 
     it "returns the request" do
       get :show, params: {id: oracle_request.id.to_s}

backend/spec/controllers/api/v1/promotion_rates_controller_spec.rb

@@ -29,7 +29,7 @@
   end
 
   describe "update" do
-    let!(:promotion_rate) { PromotionRate.create!(checkin_id: checkin.id, score: 5) }
+    let!(:promotion_rate) { create(:promotion_rate, checkin_id: checkin.id, score: 5) }
 
     it "updates the score and feedback" do
       put :update, params: {
@@ -55,7 +55,7 @@
   end
 
   describe "show" do
-    let!(:promotion_rate) { PromotionRate.create!(checkin_id: checkin.id, score: 5) }
+    let!(:promotion_rate) { create(:promotion_rate, checkin_id: checkin.id, score: 5) }
 
     it "returns the rating" do
       get :show, params: {id: promotion_rate.id.to_s}

backend/spec/controllers/api/v1/topic_followings_controller_spec.rb

@@ -6,7 +6,7 @@
   let(:symptom) { create(:symptom) }
 
   let!(:topic_following) do
-    TopicFollowing.create!(encrypted_user_id: user.encrypted_id, tag_ids: [tag.id])
+    create(:topic_following, encrypted_user_id: user.encrypted_id, tag_ids: [tag.id])
   end
 
   before { sign_in user }
@@ -21,7 +21,7 @@
 
     context "when it belongs to somebody else" do
       let!(:topic_following) do
-        TopicFollowing.create!(encrypted_user_id: create(:user).encrypted_id)
+        create(:topic_following)
       end
 
       it "is refused" do
@@ -72,7 +72,7 @@
 
     context "when it belongs to somebody else" do
       let!(:topic_following) do
-        TopicFollowing.create!(encrypted_user_id: create(:user).encrypted_id)
+        create(:topic_following)
       end
 
       it "is refused and changes nothing" do

backend/spec/factories/harvey_bradshaw_indices.rb

@@ -0,0 +1,10 @@
+FactoryBot.define do
+  factory :harvey_bradshaw_index do
+    checkin_id { FactoryBot.create(:checkin).id }
+
+    stools { 3 }
+    well_being { 1 }
+    abdominal_mass { 0 }
+    abdominal_pain { 2 }
+  end
+end

backend/spec/factories/oracle_requests.rb

@@ -0,0 +1,6 @@
+FactoryBot.define do
+  factory :oracle_request do
+    age { 30 }
+    sequence(:token) { |n| "oracle-token-#{n}" }
+  end
+end

backend/spec/factories/topic_followings.rb

@@ -1,4 +1,5 @@
 FactoryBot.define do
   factory :topic_following do
+    encrypted_user_id { FactoryBot.create(:user).encrypted_id }
   end
 end

backend/spec/mailers/promotion_rate/low_rate_mailer_spec.rb

@@ -0,0 +1,38 @@
+require "rails_helper"
+
+# Reached only from `rake oneoff:send_promotion_rate_low_rate`, which stringifies every
+# value before handing it to the view. The examples use the same shape that task
+# produces rather than model instances.
+RSpec.describe PromotionRate::LowRateMailer, type: :mailer do
+  # ApplicationMailer captures the From address into default_params at class load, so
+  # stubbing the config it reads would be too late. Override the stored default instead.
+  before do
+    allow(described_class).to receive(:default_params)
+      .and_return(described_class.default_params.merge(from: "from@some.email"))
+  end
+
+  let(:start_date) { "17-09-2017" }
+  let(:end_date) { "22-09-2017" }
+  let(:objects) do
+    [{"_id" => "1", "score" => "2", "feedback" => "rough week", "date" => "2017-09-18"}]
+  end
+  let(:mail) { described_class.show("ops@flaredown.com", objects, start_date, end_date) }
+
+  it "renders the headers" do
+    expect(mail.subject).to eq I18n.t("promotion_rate.low_rate.subject")
+    expect(mail.to).to eq ["ops@flaredown.com"]
+    expect(mail.from).to eq ["from@some.email"]
+  end
+
+  it "shows the date range" do
+    expect(mail.body.encoded).to include "#{start_date} - #{end_date}"
+  end
+
+  it "shows the score, the feedback and the date" do
+    body = mail.body.encoded
+
+    expect(body).to include "rough week"
+    expect(body).to match(/Score:\s*2/)
+    expect(body).to include "2017-09-18"
+  end
+end

backend/spec/mailers/promotion_rate/statistic_mailer_spec.rb

@@ -0,0 +1,39 @@
+require "rails_helper"
+
+# Reached only from `rake oneoff:send_promotion_rate_statistic`, which hands the output
+# of `PromotionRate.group_by_score_and_date` straight to the view -- string-keyed
+# hashes, not model instances. The examples use the same shape that task produces.
+RSpec.describe PromotionRate::StatisticMailer, type: :mailer do
+  # ApplicationMailer captures the From address into default_params at class load, so
+  # stubbing the config it reads would be too late. Override the stored default instead.
+  before do
+    allow(described_class).to receive(:default_params)
+      .and_return(described_class.default_params.merge(from: "from@some.email"))
+  end
+
+  let(:start_date) { "17-09-2017" }
+  let(:end_date) { "22-09-2017" }
+  let(:objects) { [{"_id" => 3, "count" => 7}, {"_id" => 1, "count" => 2}] }
+  let(:mail) { described_class.show("ops@flaredown.com", objects, start_date, end_date) }
+
+  it "renders the headers" do
+    expect(mail.subject).to eq I18n.t("promotion_rate.statistic.subject")
+    expect(mail.to).to eq ["ops@flaredown.com"]
+    expect(mail.from).to eq ["from@some.email"]
+  end
+
+  it "shows the date range and each score with its tally" do
+    body = mail.body.encoded
+
+    expect(body).to include "#{start_date} - #{end_date}"
+    expect(body).to include "Amount:"
+    expect(body).to match(/Score:\s*1/)
+    expect(body).to match(/Score:\s*3/)
+  end
+
+  it "orders the scores ascending regardless of the order given" do
+    scores = mail.body.encoded.scan(/Score:\s*(\d+)/).flatten
+
+    expect(scores).to eq %w[1 3]
+  end
+end