avm2: Add make_error_1126 function and use it

Author: Lord-McSweeney

core/src/avm2/error.rs

@@ -768,6 +768,20 @@ pub fn make_error_1125<'gc>(
     }
 }
 
+#[inline(never)]
+#[cold]
+pub fn make_error_1126<'gc>(activation: &mut Activation<'_, 'gc>) -> Error<'gc> {
+    let err = range_error(
+        activation,
+        "Error #1126: Cannot change the length of a fixed Vector.",
+        1126,
+    );
+    match err {
+        Ok(err) => Error::avm_error(err),
+        Err(err) => err,
+    }
+}
+
 #[inline(never)]
 #[cold]
 pub fn make_error_1127<'gc>(activation: &mut Activation<'_, 'gc>) -> Error<'gc> {

core/src/avm2/vector.rs

@@ -2,7 +2,7 @@
 
 use crate::avm2::activation::Activation;
 use crate::avm2::class::Class;
-use crate::avm2::error::{make_error_1125, range_error};
+use crate::avm2::error::{make_error_1125, make_error_1126};
 use crate::avm2::value::Value;
 use crate::avm2::Error;
 use gc_arena::Collect;
@@ -56,11 +56,7 @@ impl<'gc> VectorStorage<'gc> {
 
     pub fn check_fixed(&self, activation: &mut Activation<'_, 'gc>) -> Result<(), Error<'gc>> {
         if self.is_fixed {
-            return Err(Error::avm_error(range_error(
-                activation,
-                "Error #1126: Cannot change the length of a fixed Vector.",
-                1126,
-            )?));
+            return Err(make_error_1126(activation));
         }
         Ok(())
     }