Skip to content

Conversation

@smartinellibenedetti
Copy link
Contributor

Note: will move it to ready for review once I double check circleci

@smartinellibenedetti smartinellibenedetti added this to the 5.18.0 milestone Dec 2, 2025
@fdevans fdevans self-requested a review December 3, 2025 15:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR integrates Cloudsmith authentication into the project to enable access to PagerDuty internal npm packages. The changes configure the npm registry to use Cloudsmith's private registry at npm.artifacts.pd-internal.com, which hosts internal packages like openapi-explorer. The setup includes documentation for both PagerDuty employees with Cloudsmith access and external contributors who need to work around the authentication requirement.

Key changes:

  • Added .npmrc configuration to point npm to the Cloudsmith registry with token-based authentication
  • Updated CI/CD workflows (GitHub Actions and CircleCI) to include the CLOUDSMITH_NPM_TOKEN secret
  • Documented setup instructions in README.md for different user scenarios

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File Description
.npmrc Configures npm to use Cloudsmith registry with environment variable-based authentication
README.md Adds documentation for Cloudsmith authentication setup with instructions for employees and contributors
.github/workflows/snyk-scan.yml Adds CLOUDSMITH_NPM_TOKEN environment variable to enable dependency installation in security scanning workflow
.circleci/config.yml Adds Cloudsmith context to build job to provide authentication token

Co-authored-by: Copilot <[email protected]>
Copy link
Contributor

Copilot AI commented Dec 3, 2025

@fdevans I've opened a new pull request, #1740, to work on those changes. Once the pull request is ready, I'll request review from you.

@fdevans fdevans merged commit 1d8b91d into 4.0.x Dec 3, 2025
3 checks passed
@fdevans fdevans deleted the chore-enable-cloudsmith branch December 3, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants