-
Notifications
You must be signed in to change notification settings - Fork 164
Enable cloudsmith in the project #1738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR integrates Cloudsmith authentication into the project to enable access to PagerDuty internal npm packages. The changes configure the npm registry to use Cloudsmith's private registry at npm.artifacts.pd-internal.com, which hosts internal packages like openapi-explorer. The setup includes documentation for both PagerDuty employees with Cloudsmith access and external contributors who need to work around the authentication requirement.
Key changes:
- Added
.npmrcconfiguration to point npm to the Cloudsmith registry with token-based authentication - Updated CI/CD workflows (GitHub Actions and CircleCI) to include the
CLOUDSMITH_NPM_TOKENsecret - Documented setup instructions in README.md for different user scenarios
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.npmrc |
Configures npm to use Cloudsmith registry with environment variable-based authentication |
README.md |
Adds documentation for Cloudsmith authentication setup with instructions for employees and contributors |
.github/workflows/snyk-scan.yml |
Adds CLOUDSMITH_NPM_TOKEN environment variable to enable dependency installation in security scanning workflow |
.circleci/config.yml |
Adds Cloudsmith context to build job to provide authentication token |
Co-authored-by: Copilot <[email protected]>
Note: will move it to ready for review once I double check circleci