SAK-52138 Assignments: Selecting LTI submission type & ‘Assign To’ value

[hornersa]

Jira: https://sakaiproject.atlassian.net/browse/SAK-52138

Summary by CodeRabbit

• Bug Fixes
  • Fixed an issue where a specific option was being automatically selected. Users can now make deliberate choices without implicit selections being applied.

[coderabbitai]

Walkthrough

Removed automatic checkbox selection logic in the assignment editor template. When submission type is 6 (External Tool), the code previously auto-checked the "site" checkbox through DOM manipulation. This change removes that implicit selection behavior.

Changes

Cohort / File(s)	Change Summary
Assignment Editor Template assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_new_edit_assignment.vm	Removed DOM manipulation that automatically checks the "site" checkbox when submission type is 6

Possibly related PRs

• SAK-52068 Turnitin Hide Content Review options when Submission Type is set to External Tool #14158: Also modifies the same VM template's submission-type handling for type 6, specifically hiding Turnitin/content-review UI for external tools.

Suggested reviewers

• ern
• ottenhoff
• jesusmmp

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title references a Jira issue (SAK-52138) and mentions 'Assignments: Selecting LTI submission type & Assign To value', which aligns with the actual change of removing automatic checkbox selection in the assignment editor.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0ccc342 and d2b468e.

📒 Files selected for processing (1)

• assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_new_edit_assignment.vm (0 hunks)

💤 Files with no reviewable changes (1)

• assignment/tool/src/webapp/vm/assignment/chef_assignments_instructor_new_edit_assignment.vm

⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: sakai-deploy
• GitHub Check: maven-build

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

This PR has been automatically marked as stale due to 10 days of inactivity. It will be closed in 4 days unless there is new activity.