Merge pull request #274 from samgozman/short-fork-2.0_fixes

Exceptions fixes

Author: samgozman

backend/src/models/barchart/barchart.service.ts

@@ -40,7 +40,6 @@ export class BarchartService {
         .annual();
       barchartFinancialsIncome = await financials.income(stockTicker).annual();
     } catch (error) {
-      console.error(error);
       return null;
     }
 
@@ -70,12 +69,16 @@ export class BarchartService {
 
     return {
       longTermDebt: longDebt ? [...longDebt].reverse() : null,
-      shareholdersEquity: [
-        ...barchartFinancialsBalance.shareholdersEquity.total,
-      ].reverse(),
-      netIncome: [...barchartFinancialsIncome.netIncome].reverse(),
-      revenue: [...barchartFinancialsIncome.sales].reverse(),
-      dates: [...dates].reverse(),
+      shareholdersEquity: barchartFinancialsBalance.shareholdersEquity.total
+        ? [...barchartFinancialsBalance.shareholdersEquity.total].reverse()
+        : [],
+      netIncome: barchartFinancialsIncome.netIncome
+        ? [...barchartFinancialsIncome.netIncome].reverse()
+        : [],
+      revenue: barchartFinancialsIncome.sales
+        ? [...barchartFinancialsIncome.sales].reverse()
+        : [],
+      dates: dates ? [...dates].reverse() : [],
     };
   }
 
@@ -84,7 +87,6 @@ export class BarchartService {
     try {
       barchartOverview = await quotes.overview(stockTicker);
     } catch (error) {
-      console.error(error);
       return null;
     }
 

backend/src/models/finviz/finviz.service.ts

@@ -62,8 +62,6 @@ export class FinvizService {
       };
       return data;
     } catch (error) {
-      // TODO: Log error to sentry, add exception filter
-      console.error(error);
       return null;
     }
   }

backend/src/models/shortsqueeze/shortsqueeze.service.ts

@@ -14,8 +14,11 @@ export class ShortsqueezeService {
     return this.squeezeRepository.set(stockTicker, data);
   }
 
-  async fetch(stockTicker: string): Promise<IShortsqueeze> {
+  async fetch(stockTicker: string): Promise<IShortsqueeze | null> {
     const squeeze = await shortsqueeze(stockTicker);
+    if (!squeeze) {
+      return null;
+    }
 
     return {
       shortFlow: squeeze ? squeeze.shortPercentOfFloat : undefined,

backend/src/models/tightshorts/tightshorts.service.ts

@@ -1,6 +1,7 @@
 import { Injectable } from '@nestjs/common';
 import { ConfigService } from '@nestjs/config';
 import axios from 'axios';
+import type { AxiosRequestConfig } from 'axios';
 import { TightshortsRepository } from './tightshorts.repository';
 import type { ITightshorts } from './interfaces/tightshorts.interface';
 import type { ITightshortsChart } from './interfaces/chart.interface';
@@ -20,8 +21,8 @@ export class TightshortsService {
     return this.tightshortsRepository.set(stockTicker, data);
   }
 
-  async fetch(stockTicker: string): Promise<ITightshorts> {
-    const config = {
+  async fetch(stockTicker: string): Promise<ITightshorts | null> {
+    const config: AxiosRequestConfig<any> = {
       method: 'get',
       url: `${this.configService.get(
         'SHORT_API_URL',
@@ -30,9 +31,15 @@ export class TightshortsService {
         token: this.configService.get('SHORT_API_KEY'),
         'Content-Type': 'application/json',
       },
+      validateStatus: (status) =>
+        (status >= 200 && status < 300) || status === 404,
     };
 
-    const api = (await axios(config)).data;
+    const response = await axios(config);
+    if (response.status === 404) {
+      return null;
+    }
+    const api = response.data;
 
     const currentShortVolume =
       ((api.volume[0].shortVolume / api.volume[0].totalVolume) * 100).toFixed(