Merge pull request #259 from Laerte/fix/drop-tree-xml

wRAR · web-flow · commit deceb29371ae · 2022-10-28T20:15:43.000+05:00
fix: `AttributeError` because XML parser don't have `drop_tree` method
diff --git a/parsel/selector.py b/parsel/selector.py
@@ -550,7 +550,7 @@ def drop(self):
         Drop matched nodes from the parent element.
         """
         try:
-            self.root.getparent()
+            parent = self.root.getparent()
         except AttributeError:
             # 'str' object has no attribute 'getparent'
             raise CannotRemoveElementWithoutRoot(
@@ -561,7 +561,10 @@ def drop(self):
             )
 
         try:
-            self.root.drop_tree()
+            if self.type == "xml":
+                parent.remove(self.root)
+            else:
+                self.root.drop_tree()
         except (AttributeError, AssertionError):
             # 'NoneType' object has no attribute 'drop'
             raise CannotDropElementWithoutParent(
diff --git a/tests/test_selector.py b/tests/test_selector.py
@@ -1326,3 +1326,10 @@ def test_dont_remove_text_after_deleted_element(self) -> None:
         self.assertEqual(
             sel.get(), "<html><body>Text before. Text after.</body></html>"
         )
+
+    def test_drop_with_xml_type(self) -> None:
+        sel = self.sscls(text="<a><b></b><c/></a>", type="xml")
+        el = sel.xpath("//b")[0]
+        assert el.root.getparent() is not None
+        el.drop()
+        assert sel.get() == "<a><c/></a>"
