Skip to content

Commit 0b9edd4

Browse files
authored
windows10: Add bash to PATH (#67)
this patch fixes #53 by adding bash to PATH in the same way as [github’s own images](https://github.com/actions/runner-images/blob/aab6e2778741c10551dca5dba356433b7fa1a6df/images/windows/scripts/build/Install-Git.ps1#L29). this option doesn’t actually seem to override stock windows tools like `find` and `sort` until you’re _inside_ bash (git-for-windows/build-extra#653), so i think we can do this without any unwanted side effects. <img width="1024" height="768" alt="Screenshot_servo-windows10_2025-11-05_12:23:39" src="https://github.com/user-attachments/assets/4d86bec4-d228-4205-b4ff-259e7977972c" />
1 parent e04d0d1 commit 0b9edd4

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

profiles/servo-windows10/boot-script

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ if (!(Test-Path .\image-built)) {
2222
# Note: installer automatically uninstalls first if needed, so the check is just there to save time
2323
if (!(Test-Path 'C:\Program Files\Git\cmd\git.exe')) {
2424
curl.exe -fsSLO 'http://192.168.100.1:8000/image-deps/windows10/Git-2.45.1-64-bit.exe'; Check
25-
.\Git-2.45.1-64-bit.exe /silent | Out-Default; Check
25+
# `CmdTools` is “Use Git and optional Unix tools from the Command Prompt”, and is required
26+
# by many composite actions expecting to be able to run bash scripts on all platforms.
27+
# This is what GitHub’s images use, and it does not seem to override stock Windows tools.
28+
# <https://github.com/git-for-windows/build-extra/pull/653>
29+
.\Git-2.45.1-64-bit.exe /silent /o:PathOption=CmdTools | Out-Default; Check
2630
}
2731

2832
# Install Python, for checkouts without servo#34504

0 commit comments

Comments
 (0)