Add --log-dir option and improve ENABLE_UI support #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add --log-dir CLI option to specify directory for log files - Update LoggingManager and WorkerLoggingManager to support custom log directory - Log files (genai_bench.log and genai_bench_worker_*.log) can now be written to specified directory - Improve ENABLE_UI to support multiple truthy values: true, TRUE, 1, yes, YES, on, ON (case-insensitive) - Update DistributedConfig to pass log_dir to worker processes
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
github-actions
bot
added
distributed
added 2 commits
November 12, 2025 05:52
- Add --log-dir CLI option to specify directory for log files - Update LoggingManager and WorkerLoggingManager to support custom log directory - Log files (genai_bench.log and genai_bench_worker_*.log) can now be written to specified directory - Improve ENABLE_UI to support multiple truthy values: true, TRUE, 1, yes, YES, on, ON (case-insensitive) - Update DistributedConfig to pass log_dir to worker processes - Add comprehensive tests for ENABLE_UI improvements (16 test cases)
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for a configurable log directory via a new
--log-dirCLI option. BothLoggingManagerandWorkerLoggingManagerwere updated to write log files (genai_bench.logandgenai_bench_worker_*.log) to the specified directory. TheENABLE_UIflag now accepts multiple truthy values (true,1,yes,on,etc.) in a case-insensitive manner. Additionally,DistributedConfigwas enhanced to propagate thelog_dirsetting to worker processes.PR Type / Label
/kind enhancement
Related Issue
Fix #113 #114
Changes
Correctness Tests
Checklist
git pull origin main)make checkto ensure code is properly formatted and passes all lint checksmake testormake test_changedto verify test coverage (~90% required)Additional Information
Add any other context, screenshots, or information about the PR here.