Skip to content

remove with_sharding_constraint #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

remove with_sharding_constraint #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions python/sgl_jax/srt/layers/sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@
from jax import lax
from jax import numpy as jnp
from jax import random
from jax.sharding import Mesh, NamedSharding
from jax.sharding import PartitionSpec as P
from jax.sharding import Mesh

from sgl_jax.srt.layers.binary_search import topk_mask, topp_mask
from sgl_jax.srt.layers.logits_processor import LogitsProcessorOutput
Expand All @@ -30,8 +29,6 @@ def _regular_sampling(self, operands):
"""Regular sampling branch"""
logits, sampling_metadata, positions, rng, mesh, use_sort_for_toppk_minp = operands

logits = lax.with_sharding_constraint(logits, NamedSharding(mesh, P(None, None)))

# Validate broadcast compatibility for temperature division
logits_batch_size = logits.shape[0]
temperatures_shape = sampling_metadata.temperatures.shape
Expand Down